[llvm] 3c03108 - [ARM] Enable verifyInstructionPredicates (#139262)

via llvm-commits llvm-commits at lists.llvm.org
Mon May 12 01:04:51 PDT 2025


Author: David Green
Date: 2025-05-12T09:04:48+01:00
New Revision: 3c0310876551d8206853e4a0752c369afdaaaa09

URL: https://github.com/llvm/llvm-project/commit/3c0310876551d8206853e4a0752c369afdaaaa09
DIFF: https://github.com/llvm/llvm-project/commit/3c0310876551d8206853e4a0752c369afdaaaa09.diff

LOG: [ARM] Enable verifyInstructionPredicates (#139262)

All the tests pass and a bootstrap and run of the llvm-test-suite passed
successfully. Enable verifyInstructionPredicates so that instructions
which are invalid with the current set of features produce an error.

Added: 
    

Modified: 
    llvm/lib/Target/ARM/ARMAsmPrinter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp
index b71a1faa0d520..2505a67727aad 100644
--- a/llvm/lib/Target/ARM/ARMAsmPrinter.cpp
+++ b/llvm/lib/Target/ARM/ARMAsmPrinter.cpp
@@ -1442,9 +1442,8 @@ void ARMAsmPrinter::EmitUnwindingInstruction(const MachineInstr *MI) {
 #include "ARMGenMCPseudoLowering.inc"
 
 void ARMAsmPrinter::emitInstruction(const MachineInstr *MI) {
-  // TODOD FIXME: Enable feature predicate checks once all the test pass.
-  // ARM_MC::verifyInstructionPredicates(MI->getOpcode(),
-  //                                   getSubtargetInfo().getFeatureBits());
+  ARM_MC::verifyInstructionPredicates(MI->getOpcode(),
+                                      getSubtargetInfo().getFeatureBits());
 
   const DataLayout &DL = getDataLayout();
   MCTargetStreamer &TS = *OutStreamer->getTargetStreamer();


        


More information about the llvm-commits mailing list