[llvm] [Debuginfod] Use StringRef::consume_back (NFC) (PR #139483)
via llvm-commits
llvm-commits at lists.llvm.org
Sun May 11 17:05:48 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-debuginfo
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/139483.diff
1 Files Affected:
- (modified) llvm/lib/Debuginfod/Debuginfod.cpp (+1-2)
``````````diff
diff --git a/llvm/lib/Debuginfod/Debuginfod.cpp b/llvm/lib/Debuginfod/Debuginfod.cpp
index db316a1b37b3b..12f817c9e4bf0 100644
--- a/llvm/lib/Debuginfod/Debuginfod.cpp
+++ b/llvm/lib/Debuginfod/Debuginfod.cpp
@@ -245,8 +245,7 @@ static SmallVector<std::string, 0> getHeaders() {
uint64_t LineNumber = 0;
for (StringRef Line : llvm::split((*HeadersFile)->getBuffer(), '\n')) {
LineNumber++;
- if (!Line.empty() && Line.back() == '\r')
- Line = Line.drop_back();
+ Line.consume_back("\r");
if (!isHeader(Line)) {
if (!all_of(Line, llvm::isSpace))
WithColor::warning()
``````````
</details>
https://github.com/llvm/llvm-project/pull/139483
More information about the llvm-commits
mailing list