[llvm] [Debuginfod] Use StringRef::consume_back (NFC) (PR #139483)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sun May 11 17:05:18 PDT 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139483

None

>From da79b772bc9f005dd659115e5a876c08be623441 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 11 May 2025 16:38:18 -0700
Subject: [PATCH] [Debuginfod] Use StringRef::consume_back (NFC)

---
 llvm/lib/Debuginfod/Debuginfod.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/llvm/lib/Debuginfod/Debuginfod.cpp b/llvm/lib/Debuginfod/Debuginfod.cpp
index db316a1b37b3b..12f817c9e4bf0 100644
--- a/llvm/lib/Debuginfod/Debuginfod.cpp
+++ b/llvm/lib/Debuginfod/Debuginfod.cpp
@@ -245,8 +245,7 @@ static SmallVector<std::string, 0> getHeaders() {
   uint64_t LineNumber = 0;
   for (StringRef Line : llvm::split((*HeadersFile)->getBuffer(), '\n')) {
     LineNumber++;
-    if (!Line.empty() && Line.back() == '\r')
-      Line = Line.drop_back();
+    Line.consume_back("\r");
     if (!isHeader(Line)) {
       if (!all_of(Line, llvm::isSpace))
         WithColor::warning()



More information about the llvm-commits mailing list