[llvm] [Github][CI] Rename New Premerge Jobs (PR #138024)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 30 14:24:34 PDT 2025
https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/138024
>From 4d7bd7f1a27fba67dc06e7a36c91daaeb9bb50ff Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Wed, 30 Apr 2025 21:15:41 +0000
Subject: [PATCH 1/2] [Github][CI] Rename New Premerge Jobs
This patch renames the new premerge job as suggested in
https://discourse.llvm.org/t/github-ci-notifications-and-main-branch/85868/10.
This uses more industry standard terms (like CI vs premerge checks which
might be somewhat of a LLVM CI idiom?) and makes it more generic if we
end up doing postcommit testing through Github.
---
.ci/metrics/metrics.py | 4 ++--
.github/workflows/premerge.yaml | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py
index a5ee893650d63..5c53ebf6ade02 100644
--- a/.ci/metrics/metrics.py
+++ b/.ci/metrics/metrics.py
@@ -29,8 +29,8 @@
# name.
GITHUB_JOB_TO_TRACK = {
"github_llvm_premerge_checks": {
- "Linux Premerge Checks (Test Only - Please Ignore Results)": "premerge_linux",
- "Windows Premerge Checks (Test Only - Please Ignore Results)": "premerge_windows",
+ "Build and Test Linux (Test Only - Please Ignore Results)": "premerge_linux",
+ "Build and Test Windows (Test Only - Please Ignore Results)": "premerge_windows",
}
}
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index c315ee37646d2..5defe92debd6b 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -1,4 +1,4 @@
-name: LLVM Premerge Checks
+name: LLVM CI Checks
permissions:
contents: read
@@ -25,7 +25,7 @@ concurrency:
jobs:
premerge-checks-linux:
- name: Linux Premerge Checks (Test Only - Please Ignore Results)
+ name: Build and Test Linux (Test Only - Please Ignore Results)
if: >-
github.repository_owner == 'llvm' &&
(github.event_name != 'pull_request' || github.event.action != 'closed')
@@ -74,7 +74,7 @@ jobs:
include-hidden-files: 'true'
premerge-checks-windows:
- name: Windows Premerge Checks (Test Only - Please Ignore Results)
+ name: Build and Test Windows (Test Only - Please Ignore Results)
if: >-
github.repository_owner == 'llvm' &&
(github.event_name != 'pull_request' || github.event.action != 'closed')
>From 3de112461a833f708082944534d95d1ed6040cce Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Wed, 30 Apr 2025 21:24:22 +0000
Subject: [PATCH 2/2] feedback
---
.ci/metrics/metrics.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.ci/metrics/metrics.py b/.ci/metrics/metrics.py
index 5c53ebf6ade02..b5c99e6c8dcbf 100644
--- a/.ci/metrics/metrics.py
+++ b/.ci/metrics/metrics.py
@@ -21,7 +21,7 @@
# Lists the Github workflows we want to track. Maps the Github job name to
# the metric name prefix in grafana.
# This metric name is also used as a key in the job->name map.
-GITHUB_WORKFLOW_TO_TRACK = {"LLVM Premerge Checks": "github_llvm_premerge_checks"}
+GITHUB_WORKFLOW_TO_TRACK = {"LLVM CI Checks": "github_llvm_premerge_checks"}
# Lists the Github jobs to track for a given workflow. The key is the stable
# name (metric name) of the workflow (see GITHUB_WORKFLOW_TO_TRACK).
More information about the llvm-commits
mailing list