[llvm] [AMDGPU] Simplify GCNTTIImpl::isValidAddrSpaceCast. NFCI. (PR #137986)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 30 09:22:01 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Jay Foad (jayfoad)
<details>
<summary>Changes</summary>
This just removes some code that references specific address spaces.
---
Full diff: https://github.com/llvm/llvm-project/pull/137986.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h (+2-14)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
index f6f7bd4bfcf5b..c4520f8cd3311 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
@@ -182,20 +182,8 @@ class GCNTTIImpl final : public BasicTTIImplBase<GCNTTIImpl> {
if (FromAS == ToAS)
return false;
- if (FromAS == AMDGPUAS::FLAT_ADDRESS)
- return AMDGPU::isExtendedGlobalAddrSpace(ToAS) ||
- ToAS == AMDGPUAS::LOCAL_ADDRESS ||
- ToAS == AMDGPUAS::PRIVATE_ADDRESS;
-
- if (AMDGPU::isExtendedGlobalAddrSpace(FromAS))
- return AMDGPU::isFlatGlobalAddrSpace(ToAS) ||
- ToAS == AMDGPUAS::CONSTANT_ADDRESS_32BIT;
-
- if (FromAS == AMDGPUAS::LOCAL_ADDRESS ||
- FromAS == AMDGPUAS::PRIVATE_ADDRESS)
- return ToAS == AMDGPUAS::FLAT_ADDRESS;
-
- return false;
+ // Casts between any aliasing address spaces are valid.
+ return AMDGPU::addrspacesMayAlias(FromAS, ToAS);
}
bool addrspacesMayAlias(unsigned AS0, unsigned AS1) const override {
``````````
</details>
https://github.com/llvm/llvm-project/pull/137986
More information about the llvm-commits
mailing list