[llvm] [AMDGPU] Simplify GCNTTIImpl::isValidAddrSpaceCast. NFCI. (PR #137986)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 30 09:21:28 PDT 2025


https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/137986

This just removes some code that references specific address spaces.


>From 611adaf7d7969d97edc97577bd75835e82f7da75 Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Wed, 30 Apr 2025 17:19:20 +0100
Subject: [PATCH] [AMDGPU] Simplify GCNTTIImpl::isValidAddrSpaceCast. NFCI.

This just removes some code that references specific address spaces.
---
 .../Target/AMDGPU/AMDGPUTargetTransformInfo.h    | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
index f6f7bd4bfcf5b..c4520f8cd3311 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
@@ -182,20 +182,8 @@ class GCNTTIImpl final : public BasicTTIImplBase<GCNTTIImpl> {
     if (FromAS == ToAS)
       return false;
 
-    if (FromAS == AMDGPUAS::FLAT_ADDRESS)
-      return AMDGPU::isExtendedGlobalAddrSpace(ToAS) ||
-             ToAS == AMDGPUAS::LOCAL_ADDRESS ||
-             ToAS == AMDGPUAS::PRIVATE_ADDRESS;
-
-    if (AMDGPU::isExtendedGlobalAddrSpace(FromAS))
-      return AMDGPU::isFlatGlobalAddrSpace(ToAS) ||
-             ToAS == AMDGPUAS::CONSTANT_ADDRESS_32BIT;
-
-    if (FromAS == AMDGPUAS::LOCAL_ADDRESS ||
-        FromAS == AMDGPUAS::PRIVATE_ADDRESS)
-      return ToAS == AMDGPUAS::FLAT_ADDRESS;
-
-    return false;
+    // Casts between any aliasing address spaces are valid.
+    return AMDGPU::addrspacesMayAlias(FromAS, ToAS);
   }
 
   bool addrspacesMayAlias(unsigned AS0, unsigned AS1) const override {



More information about the llvm-commits mailing list