[llvm] [TableGen] Simplify a string comparison (NFC) (PR #137584)

via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 27 23:28:26 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-backend-directx

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/137584.diff


1 Files Affected:

- (modified) llvm/utils/TableGen/DXILEmitter.cpp (+1-2) 


``````````diff
diff --git a/llvm/utils/TableGen/DXILEmitter.cpp b/llvm/utils/TableGen/DXILEmitter.cpp
index 0364b02c2483d..09ce9f3027410 100644
--- a/llvm/utils/TableGen/DXILEmitter.cpp
+++ b/llvm/utils/TableGen/DXILEmitter.cpp
@@ -172,10 +172,9 @@ DXILOperationDesc::DXILOperationDesc(const Record *R) {
   // Get the operation class
   OpClass = R->getValueAsDef("OpClass")->getName();
 
-  if (!OpClass.str().compare("UnknownOpClass")) {
+  if (OpClass.str() == "UnknownOpClass")
     PrintFatalError(R, Twine("Unspecified DXIL OpClass for DXIL operation - ") +
                            OpName);
-  }
 
   auto IntrinsicSelectRecords = R->getValueAsListOfDefs("intrinsics");
   if (IntrinsicSelectRecords.size()) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/137584


More information about the llvm-commits mailing list