[llvm] [SystemZ] Fix compile time regression in adjustInliningThreshold(). (PR #137527)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 27 09:32:05 PDT 2025
================
@@ -92,29 +91,38 @@ unsigned SystemZTTIImpl::adjustInliningThreshold(const CallBase *CB) const {
}
}
- // Give bonus for globals used much in both caller and callee.
- std::set<const GlobalVariable *> CalleeGlobals;
- std::set<const GlobalVariable *> CallerGlobals;
- for (const GlobalVariable &Global : M->globals())
- for (const User *U : Global.users())
- if (const Instruction *User = dyn_cast<Instruction>(U)) {
- if (User->getParent()->getParent() == Callee)
- CalleeGlobals.insert(&Global);
- if (User->getParent()->getParent() == Caller)
- CallerGlobals.insert(&Global);
+ // Give bonus for globals used much in both caller and a relatively small
+ // callee.
+ if (Callee->getInstructionCount() < 200) {
+ std::map<const Value *, unsigned> Ptr2NumUses;
+ for (auto &BB : *Callee)
+ for (auto &I : BB) {
+ if (const auto *SI = dyn_cast<StoreInst>(&I)) {
+ if (!SI->isVolatile())
+ Ptr2NumUses[SI->getPointerOperand()]++;
----------------
nikic wrote:
It would be better to only count global uses, which will reduce the size of the map a lot.
https://github.com/llvm/llvm-project/pull/137527
More information about the llvm-commits
mailing list