[llvm] [AMDGPU] Simplify PrintField::printField (NFC) (PR #137502)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 27 00:39:36 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
We can use "constexpr if" to combine the two variants of functions.
---
Full diff: https://github.com/llvm/llvm-project/pull/137502.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp (+8-13)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp b/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp
index b05696d2dfa05..8997911aa8ae1 100644
--- a/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp
+++ b/llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp
@@ -222,22 +222,17 @@ static int get_amd_kernel_code_t_FieldIndex(StringRef name) {
class PrintField {
public:
- template <typename T, T AMDGPUMCKernelCodeT::*ptr,
- typename std::enable_if_t<!std::is_integral_v<T>, T> * = nullptr>
+ template <typename T, T AMDGPUMCKernelCodeT::*ptr>
static void printField(StringRef Name, const AMDGPUMCKernelCodeT &C,
raw_ostream &OS, MCContext &Ctx,
AMDGPUMCKernelCodeT::PrintHelper Helper) {
- OS << Name << " = ";
- const MCExpr *Value = C.*ptr;
- Helper(Value, OS, Ctx.getAsmInfo());
- }
-
- template <typename T, T AMDGPUMCKernelCodeT::*ptr,
- typename std::enable_if_t<std::is_integral_v<T>, T> * = nullptr>
- static void printField(StringRef Name, const AMDGPUMCKernelCodeT &C,
- raw_ostream &OS, MCContext &,
- AMDGPUMCKernelCodeT::PrintHelper) {
- OS << Name << " = " << (int)(C.*ptr);
+ if constexpr (!std::is_integral_v<T>) {
+ OS << Name << " = ";
+ const MCExpr *Value = C.*ptr;
+ Helper(Value, OS, Ctx.getAsmInfo());
+ } else {
+ OS << Name << " = " << (int)(C.*ptr);
+ }
}
};
``````````
</details>
https://github.com/llvm/llvm-project/pull/137502
More information about the llvm-commits
mailing list