[llvm] [llvm] Use llvm::copy_if (NFC) (PR #137480)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 26 15:57:26 PDT 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/137480
None
>From 4be66db448ac58a16c3a92f98fbde90ccedc6d59 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 26 Apr 2025 14:40:07 -0700
Subject: [PATCH] [llvm] Use llvm::copy_if (NFC)
---
.../Utils/PromoteMemoryToRegister.cpp | 13 +++---
.../GlobalISelMatchTableExecutorEmitter.cpp | 20 ++++-----
llvm/utils/TableGen/GlobalISelEmitter.cpp | 44 +++++++++----------
3 files changed, 38 insertions(+), 39 deletions(-)
diff --git a/llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp b/llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
index c0c58237ddfca..f46cddfd8587a 100644
--- a/llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
+++ b/llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
@@ -270,13 +270,12 @@ struct AllocaInfo {
DbgUserVec AllDbgUsers;
SmallVector<DbgVariableRecord *> AllDPUsers;
findDbgUsers(AllDbgUsers, AI, &AllDPUsers);
- std::copy_if(AllDbgUsers.begin(), AllDbgUsers.end(),
- std::back_inserter(DbgUsers), [](DbgVariableIntrinsic *DII) {
- return !isa<DbgAssignIntrinsic>(DII);
- });
- std::copy_if(AllDPUsers.begin(), AllDPUsers.end(),
- std::back_inserter(DPUsers),
- [](DbgVariableRecord *DVR) { return !DVR->isDbgAssign(); });
+ llvm::copy_if(AllDbgUsers, std::back_inserter(DbgUsers),
+ [](DbgVariableIntrinsic *DII) {
+ return !isa<DbgAssignIntrinsic>(DII);
+ });
+ llvm::copy_if(AllDPUsers, std::back_inserter(DPUsers),
+ [](DbgVariableRecord *DVR) { return !DVR->isDbgAssign(); });
AssignmentTracking.init(AI);
}
};
diff --git a/llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTableExecutorEmitter.cpp b/llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTableExecutorEmitter.cpp
index b7926e21ca661..ffab2fdedc5a1 100644
--- a/llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTableExecutorEmitter.cpp
+++ b/llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTableExecutorEmitter.cpp
@@ -19,17 +19,17 @@ void GlobalISelMatchTableExecutorEmitter::emitSubtargetFeatureBitsetImpl(
// Separate subtarget features by how often they must be recomputed.
SubtargetFeatureInfoMap ModuleFeatures;
- std::copy_if(SubtargetFeatures.begin(), SubtargetFeatures.end(),
- std::inserter(ModuleFeatures, ModuleFeatures.end()),
- [](const SubtargetFeatureInfoMap::value_type &X) {
- return !X.second.mustRecomputePerFunction();
- });
+ llvm::copy_if(SubtargetFeatures,
+ std::inserter(ModuleFeatures, ModuleFeatures.end()),
+ [](const SubtargetFeatureInfoMap::value_type &X) {
+ return !X.second.mustRecomputePerFunction();
+ });
SubtargetFeatureInfoMap FunctionFeatures;
- std::copy_if(SubtargetFeatures.begin(), SubtargetFeatures.end(),
- std::inserter(FunctionFeatures, FunctionFeatures.end()),
- [](const SubtargetFeatureInfoMap::value_type &X) {
- return X.second.mustRecomputePerFunction();
- });
+ llvm::copy_if(SubtargetFeatures,
+ std::inserter(FunctionFeatures, FunctionFeatures.end()),
+ [](const SubtargetFeatureInfoMap::value_type &X) {
+ return X.second.mustRecomputePerFunction();
+ });
SubtargetFeatureInfo::emitComputeAvailableFeatures(
getTarget().getName(), getClassName(), "computeAvailableModuleFeatures",
diff --git a/llvm/utils/TableGen/GlobalISelEmitter.cpp b/llvm/utils/TableGen/GlobalISelEmitter.cpp
index b9561c137ec8b..8d0403ae43068 100644
--- a/llvm/utils/TableGen/GlobalISelEmitter.cpp
+++ b/llvm/utils/TableGen/GlobalISelEmitter.cpp
@@ -2273,10 +2273,10 @@ void GlobalISelEmitter::emitAdditionalImpl(raw_ostream &OS) {
void GlobalISelEmitter::emitMIPredicateFns(raw_ostream &OS) {
std::vector<const Record *> MatchedRecords;
- std::copy_if(AllPatFrags.begin(), AllPatFrags.end(),
- std::back_inserter(MatchedRecords), [](const Record *R) {
- return !R->getValueAsString("GISelPredicateCode").empty();
- });
+ llvm::copy_if(AllPatFrags, std::back_inserter(MatchedRecords),
+ [](const Record *R) {
+ return !R->getValueAsString("GISelPredicateCode").empty();
+ });
emitMIPredicateFnsImpl<const Record *>(
OS,
" const MachineFunction &MF = *MI.getParent()->getParent();\n"
@@ -2291,13 +2291,13 @@ void GlobalISelEmitter::emitMIPredicateFns(raw_ostream &OS) {
void GlobalISelEmitter::emitI64ImmPredicateFns(raw_ostream &OS) {
std::vector<const Record *> MatchedRecords;
- std::copy_if(AllPatFrags.begin(), AllPatFrags.end(),
- std::back_inserter(MatchedRecords), [](const Record *R) {
- bool Unset;
- return !R->getValueAsString("ImmediateCode").empty() &&
- !R->getValueAsBitOrUnset("IsAPFloat", Unset) &&
- !R->getValueAsBit("IsAPInt");
- });
+ llvm::copy_if(AllPatFrags, std::back_inserter(MatchedRecords),
+ [](const Record *R) {
+ bool Unset;
+ return !R->getValueAsString("ImmediateCode").empty() &&
+ !R->getValueAsBitOrUnset("IsAPFloat", Unset) &&
+ !R->getValueAsBit("IsAPInt");
+ });
emitImmPredicateFnsImpl<const Record *>(
OS, "I64", "int64_t", ArrayRef<const Record *>(MatchedRecords),
&getPatFragPredicateEnumName,
@@ -2307,12 +2307,12 @@ void GlobalISelEmitter::emitI64ImmPredicateFns(raw_ostream &OS) {
void GlobalISelEmitter::emitAPFloatImmPredicateFns(raw_ostream &OS) {
std::vector<const Record *> MatchedRecords;
- std::copy_if(AllPatFrags.begin(), AllPatFrags.end(),
- std::back_inserter(MatchedRecords), [](const Record *R) {
- bool Unset;
- return !R->getValueAsString("ImmediateCode").empty() &&
- R->getValueAsBitOrUnset("IsAPFloat", Unset);
- });
+ llvm::copy_if(AllPatFrags, std::back_inserter(MatchedRecords),
+ [](const Record *R) {
+ bool Unset;
+ return !R->getValueAsString("ImmediateCode").empty() &&
+ R->getValueAsBitOrUnset("IsAPFloat", Unset);
+ });
emitImmPredicateFnsImpl<const Record *>(
OS, "APFloat", "const APFloat &",
ArrayRef<const Record *>(MatchedRecords), &getPatFragPredicateEnumName,
@@ -2322,11 +2322,11 @@ void GlobalISelEmitter::emitAPFloatImmPredicateFns(raw_ostream &OS) {
void GlobalISelEmitter::emitAPIntImmPredicateFns(raw_ostream &OS) {
std::vector<const Record *> MatchedRecords;
- std::copy_if(AllPatFrags.begin(), AllPatFrags.end(),
- std::back_inserter(MatchedRecords), [](const Record *R) {
- return !R->getValueAsString("ImmediateCode").empty() &&
- R->getValueAsBit("IsAPInt");
- });
+ llvm::copy_if(AllPatFrags, std::back_inserter(MatchedRecords),
+ [](const Record *R) {
+ return !R->getValueAsString("ImmediateCode").empty() &&
+ R->getValueAsBit("IsAPInt");
+ });
emitImmPredicateFnsImpl<const Record *>(
OS, "APInt", "const APInt &", ArrayRef<const Record *>(MatchedRecords),
&getPatFragPredicateEnumName,
More information about the llvm-commits
mailing list