[llvm] [LLVM][CodeGen][X86] Add ConstantInt/FP based vector support to MachineInstr fixup and printing code. (PR #137331)

[Paul Walker via llvm-commits]

paulwalker-arm wrote:

> > > do you have actual test check changes for this please?
> > 
> > 
> > I don't understand what you mean. I've added RUN lines to show the output now remains unchanged when the new code paths are enabled.
> 
> We usually test what modified by the change rather than silence test cases. Only NFC change don't need to test.

I see and thanks for the explanation. The problem I have is my changes are to core IR and during all previous refactoring it has been acceptable (dare I say sensible) to add RUN lines to existing tests to verify the new code paths do not change behaviour. The only time I've needed to add new tests are for cases where the existing ones do not provably exercise the affected code.  In this instance pretty much all the X86 vector tests exercise the code and so I just picked two which I know fail if any part of the PR is removed. The new RUN lines will be removed when the new code paths are enabled by default.

Is this agreeable? or should I copy the relevant tests into a dedicated file?

https://github.com/llvm/llvm-project/pull/137331