[llvm] [CodeExtractor] Improve debug info for input values. (PR #136016)

Sat Apr 26 02:35:11 PDT 2025

abidh wrote:

> LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-win-fast` running on `as-builder-3` while building `llvm` at step 7 "test-build-unified-tree-check-llvm-unit".
> 
> Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/22522
> 
> Here is the relevant piece of the build log for the reference
> ```
> Step 7 (test-build-unified-tree-check-llvm-unit) failure: test (failure)
> ...
> [735/745] Linking CXX executable unittests\Target\TargetMachineCTests.exe
> [736/745] Linking CXX executable unittests\Passes\PassBuilderBindings\PassesBindingsTests.exe
> [737/745] Linking CXX executable unittests\IR\IRTests.exe
> [738/745] Linking CXX executable unittests\tools\llvm-exegesis\LLVMExegesisTests.exe
> [739/745] Linking CXX executable unittests\Target\ARM\ARMTests.exe
> [740/745] Linking CXX executable unittests\Transforms\Coroutines\CoroTests.exe
> [741/745] Linking CXX executable unittests\Transforms\Instrumentation\InstrumentationTests.exe
> [742/745] Linking CXX executable unittests\Transforms\Scalar\ScalarTests.exe
> [743/745] Building CXX object unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CodeExtractorTest.cpp.obj
> [744/745] Linking CXX executable unittests\Transforms\Utils\UtilsTests.exe
> FAILED: unittests/Transforms/Utils/UtilsTests.exe 
> cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --intdir=unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir --rc=C:\PROGRA~2\WINDOW~4\10\bin\100226~1.0\x64\rc.exe --mt=C:\PROGRA~2\WINDOW~4\10\bin\100226~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\link.exe /nologo unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ASanStackFrameLayoutTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\BasicBlockUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CallPromotionUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CloningTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CodeExtractorTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CodeLayoutTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CodeMoverUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\DebugifyTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\FunctionComparatorTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\IntegerDivisionTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\LocalTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\LoopRotationUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\LoopUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\MemTransferLowering.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ModuleUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ScalarEvolutionExpanderTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\SizeOptsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\SSAUpdaterBulkTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\UnrollLoopTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ValueMapperTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ProfDataUtilTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\__\__\__\resources\windows_version_resource.rc.res  /out:unittests\Transforms\Utils\UtilsTests.exe /implib:unittests\Transforms\Utils\UtilsTests.lib /pdb:unittests\Transforms\Utils\UtilsTests.pdb /version:0.0 /machine:x64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console  lib\LLVMAnalysis.lib  lib\LLVMAsmParser.lib  lib\LLVMBitWriter.lib  lib\LLVMCore.lib  lib\LLVMProfileData.lib  lib\LLVMSupport.lib  lib\LLVMTransformUtils.lib  lib\LLVMPasses.lib  lib\LLVMVectorize.lib  lib\LLVMSupport.lib  lib\llvm_gtest_main.lib  lib\llvm_gtest.lib  lib\LLVMCFGuard.lib  lib\LLVMCodeGen.lib  lib\LLVMCGData.lib  lib\LLVMCodeGenTypes.lib  lib\LLVMCoroutines.lib  lib\LLVMHipStdPar.lib  lib\LLVMipo.lib  lib\LLVMBitWriter.lib  lib\LLVMVectorize.lib  lib\LLVMSandboxIR.lib  lib\LLVMFrontendOpenMP.lib  lib\LLVMFrontendOffloading.lib  lib\LLVMObjectYAML.lib  lib\LLVMFrontendAtomic.lib  lib\LLVMLinker.lib  lib\LLVMIRPrinter.lib  lib\LLVMObjCARCOpts.lib  lib\LLVMScalarOpts.lib  lib\LLVMAggressiveInstCombine.lib  lib\LLVMInstCombine.lib  lib\LLVMTarget.lib  lib\LLVMInstrumentation.lib  lib\LLVMTransformUtils.lib  lib\LLVMAnalysis.lib  lib\LLVMProfileData.lib  lib\LLVMSymbolize.lib  lib\LLVMDebugInfoPDB.lib  "C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK\lib\amd64\diaguids.lib"  lib\LLVMDebugInfoCodeView.lib  lib\LLVMDebugInfoMSF.lib  lib\LLVMDebugInfoBTF.lib  lib\LLVMDebugInfoDWARF.lib  lib\LLVMObject.lib  lib\LLVMIRReader.lib  lib\LLVMAsmParser.lib  lib\LLVMBitReader.lib  lib\LLVMMCParser.lib  lib\LLVMTextAPI.lib  lib\LLVMCore.lib  lib\LLVMRemarks.lib  lib\LLVMBitstreamReader.lib  lib\LLVMMC.lib  lib\LLVMBinaryFormat.lib  lib\LLVMTargetParser.lib  lib\LLVMSupport.lib  lib\LLVMDemangle.lib  psapi.lib  shell32.lib  ole32.lib  uuid.lib  advapi32.lib  ws2_32.lib  ntdll.lib  delayimp.lib  -delayload:shell32.dll  -delayload:ole32.dll  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
> LINK: command "C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\link.exe /nologo unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ASanStackFrameLayoutTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\BasicBlockUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CallPromotionUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CloningTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CodeExtractorTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CodeLayoutTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\CodeMoverUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\DebugifyTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\FunctionComparatorTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\IntegerDivisionTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\LocalTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\LoopRotationUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\LoopUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\MemTransferLowering.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ModuleUtilsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ScalarEvolutionExpanderTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\SizeOptsTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\SSAUpdaterBulkTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\UnrollLoopTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ValueMapperTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\ProfDataUtilTest.cpp.obj unittests\Transforms\Utils\CMakeFiles\UtilsTests.dir\__\__\__\resources\windows_version_resource.rc.res /out:unittests\Transforms\Utils\UtilsTests.exe /implib:unittests\Transforms\Utils\UtilsTests.lib /pdb:unittests\Transforms\Utils\UtilsTests.pdb /version:0.0 /machine:x64 /STACK:10000000 /INCREMENTAL:NO /subsystem:console lib\LLVMAnalysis.lib lib\LLVMAsmParser.lib lib\LLVMBitWriter.lib lib\LLVMCore.lib lib\LLVMProfileData.lib lib\LLVMSupport.lib lib\LLVMTransformUtils.lib lib\LLVMPasses.lib lib\LLVMVectorize.lib lib\LLVMSupport.lib lib\llvm_gtest_main.lib lib\llvm_gtest.lib lib\LLVMCFGuard.lib lib\LLVMCodeGen.lib lib\LLVMCGData.lib lib\LLVMCodeGenTypes.lib lib\LLVMCoroutines.lib lib\LLVMHipStdPar.lib lib\LLVMipo.lib lib\LLVMBitWriter.lib lib\LLVMVectorize.lib lib\LLVMSandboxIR.lib lib\LLVMFrontendOpenMP.lib lib\LLVMFrontendOffloading.lib lib\LLVMObjectYAML.lib lib\LLVMFrontendAtomic.lib lib\LLVMLinker.lib lib\LLVMIRPrinter.lib lib\LLVMObjCARCOpts.lib lib\LLVMScalarOpts.lib lib\LLVMAggressiveInstCombine.lib lib\LLVMInstCombine.lib lib\LLVMTarget.lib lib\LLVMInstrumentation.lib lib\LLVMTransformUtils.lib lib\LLVMAnalysis.lib lib\LLVMProfileData.lib lib\LLVMSymbolize.lib lib\LLVMDebugInfoPDB.lib C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK\lib\amd64\diaguids.lib lib\LLVMDebugInfoCodeView.lib lib\LLVMDebugInfoMSF.lib lib\LLVMDebugInfoBTF.lib lib\LLVMDebugInfoDWARF.lib lib\LLVMObject.lib lib\LLVMIRReader.lib lib\LLVMAsmParser.lib lib\LLVMBitReader.lib lib\LLVMMCParser.lib lib\LLVMTextAPI.lib lib\LLVMCore.lib lib\LLVMRemarks.lib lib\LLVMBitstreamReader.lib lib\LLVMMC.lib lib\LLVMBinaryFormat.lib lib\LLVMTargetParser.lib lib\LLVMSupport.lib lib\LLVMDemangle.lib psapi.lib shell32.lib ole32.lib uuid.lib advapi32.lib ws2_32.lib ntdll.lib delayimp.lib -delayload:shell32.dll -delayload:ole32.dll kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:unittests\Transforms\Utils\UtilsTests.exe.manifest" failed (exit code 1120) with the following output:
> CodeExtractorTest.cpp.obj : error LNK2019: unresolved external symbol "public: void __cdecl llvm::Value::dump(void)const " (?dump at Value@llvm@@QEBAXXZ) referenced in function "public: __cdecl `private: virtual void __cdecl `anonymous namespace'::CodeExtractor_ArgsDebugInfo_Test::TestBody(void)'::`2'::<lambda_1>::operator()(bool)const " (??R<lambda_1>@?1??TestBody at CodeExtractor_ArgsDebugInfo_Test@?A0x6b1fb21e@@EEAAXXZ at QEBA@_N at Z)
> unittests\Transforms\Utils\UtilsTests.exe : fatal error LNK1120: 1 unresolved externals
> ninja: build stopped: subcommand failed.
> ```

There was a debugging message left in the test that seem to be causing this failure. I have opened https://github.com/llvm/llvm-project/pull/137451 to fix it.

https://github.com/llvm/llvm-project/pull/136016