[compiler-rt] 8cd628f - doc: get rid of redundant TODO tag in FuzzedDataProvider.h (#137395)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 25 14:51:14 PDT 2025
Author: kevkevin
Date: 2025-04-25T14:51:10-07:00
New Revision: 8cd628f4729814975656121a39417b8b4843a0a3
URL: https://github.com/llvm/llvm-project/commit/8cd628f4729814975656121a39417b8b4843a0a3
DIFF: https://github.com/llvm/llvm-project/commit/8cd628f4729814975656121a39417b8b4843a0a3.diff
LOG: doc: get rid of redundant TODO tag in FuzzedDataProvider.h (#137395)
'list.size()' is determined at runtime, so using static_assert on it as
suggested by the TODO comment is not feasible and produces the following
error when done:
error: static assertion expression is not an integral constant
expression
initially referenced in https://github.com/bitcoin/bitcoin/pull/32024
Co-authored-by: Chand-ra <chandrapratap376 at gmail.com>
Added:
Modified:
compiler-rt/include/fuzzer/FuzzedDataProvider.h
Removed:
################################################################################
diff --git a/compiler-rt/include/fuzzer/FuzzedDataProvider.h b/compiler-rt/include/fuzzer/FuzzedDataProvider.h
index 11f2fbdb8c854..33ffa8bc00bfa 100644
--- a/compiler-rt/include/fuzzer/FuzzedDataProvider.h
+++ b/compiler-rt/include/fuzzer/FuzzedDataProvider.h
@@ -314,7 +314,6 @@ T FuzzedDataProvider::PickValueInArray(const std::array<T, size> &array) {
template <typename T>
T FuzzedDataProvider::PickValueInArray(std::initializer_list<const T> list) {
- // TODO(Dor1s): switch to static_assert once C++14 is allowed.
if (!list.size())
abort();
More information about the llvm-commits
mailing list