[llvm] [bazel] Depend on full Utility library in lldb (PR #137265)
Keith Smiley via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 24 16:21:37 PDT 2025
https://github.com/keith created https://github.com/llvm/llvm-project/pull/137265
Since 6493345c5ab96f60ab5ee38272fb6635f2083318 the utility library is
needed by the driver. Since liblldb's exports are limited with
-exports_symbols_list on macOS, some symbols like
`__ZN12SelectHelper10FDSetWriteEi` are not exported from liblldb and
therefore cause linker failures on macOS only. In the cmake the driver
now depends on the full utility library, even though that leads to some
duplication of symbols, so it should be safe for us to do in bazel as
well.
>From f5a27a6fef343c61a44c558f3198daeba87a0891 Mon Sep 17 00:00:00 2001
From: Keith Smiley <keithbsmiley at gmail.com>
Date: Thu, 24 Apr 2025 16:19:51 -0700
Subject: [PATCH] [bazel] Depend on full Utility library in lldb
Since 6493345c5ab96f60ab5ee38272fb6635f2083318 the utility library is
needed by the driver. Since liblldb's exports are limited with
-exports_symbols_list on macOS, some symbols like
`__ZN12SelectHelper10FDSetWriteEi` are not exported from liblldb and
therefore cause linker failures on macOS only. In the cmake the driver
now depends on the full utility library, even though that leads to some
duplication of symbols, so it should be safe for us to do in bazel as
well.
---
utils/bazel/llvm-project-overlay/lldb/BUILD.bazel | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel b/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
index 809dbefcef5e9..58f6e047e712b 100644
--- a/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/lldb/BUILD.bazel
@@ -830,7 +830,7 @@ cc_binary(
deps = [
":APIHeaders",
":Host",
- ":UtilityHeaders",
+ ":Utility",
":liblldb.wrapper",
":lldb_options_inc_gen",
"//llvm:Option",
More information about the llvm-commits
mailing list