[compiler-rt] [NFC][UBSAN] Fix minimal UBSAN test names (PR #137244)

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 24 12:51:39 PDT 2025


https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/137244

Same approach as in Asan.

Now it's going to print:
```
Failed Tests (2):
  UBSan-Minimal-i386-linux :: TestCases/icall.c
  UBSan-Minimal-x86_64-linux :: TestCases/icall.c
```

Before it was:
```
Failed Tests (2):
  UBSan-Minimal-x86_64 :: TestCases/icall.c
  UBSan-Minimal-x86_64 :: TestCases/icall.c
```


>From 141c401ccb4e34281b54aa4f4b0462bac5ae0a58 Mon Sep 17 00:00:00 2001
From: Vitaly Buka <vitalybuka at google.com>
Date: Thu, 24 Apr 2025 12:51:29 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
 =?UTF-8?q?l=20version?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Created using spr 1.3.4
---
 compiler-rt/test/ubsan_minimal/CMakeLists.txt     | 1 +
 compiler-rt/test/ubsan_minimal/lit.common.cfg.py  | 2 +-
 compiler-rt/test/ubsan_minimal/lit.site.cfg.py.in | 2 ++
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/compiler-rt/test/ubsan_minimal/CMakeLists.txt b/compiler-rt/test/ubsan_minimal/CMakeLists.txt
index e214397b492dc..dea0b4f2c07f4 100644
--- a/compiler-rt/test/ubsan_minimal/CMakeLists.txt
+++ b/compiler-rt/test/ubsan_minimal/CMakeLists.txt
@@ -10,6 +10,7 @@ set(UBSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})
 list(APPEND UBSAN_TEST_DEPS ubsan-minimal)
 
 foreach(arch ${UBSAN_TEST_ARCH})
+  string(TOLOWER "-${arch}-${OS_NAME}" UBSAN_TEST_CONFIG_SUFFIX)
   get_test_cc_for_arch(${arch} UBSAN_TEST_TARGET_CC UBSAN_TEST_TARGET_CFLAGS)
   set(CONFIG_NAME ${arch})
   configure_lit_site_cfg(
diff --git a/compiler-rt/test/ubsan_minimal/lit.common.cfg.py b/compiler-rt/test/ubsan_minimal/lit.common.cfg.py
index e60aed6512fb9..115bd244b1dd8 100644
--- a/compiler-rt/test/ubsan_minimal/lit.common.cfg.py
+++ b/compiler-rt/test/ubsan_minimal/lit.common.cfg.py
@@ -16,7 +16,7 @@ def get_required_attr(config, attr_name):
 
 # Setup source root.
 config.test_source_root = os.path.dirname(__file__)
-config.name = "UBSan-Minimal-" + config.target_arch
+config.name = "UBSan-Minimal" + config.name_suffix
 
 
 def build_invocation(compile_flags):
diff --git a/compiler-rt/test/ubsan_minimal/lit.site.cfg.py.in b/compiler-rt/test/ubsan_minimal/lit.site.cfg.py.in
index 10018e9c84359..83a28246d75af 100644
--- a/compiler-rt/test/ubsan_minimal/lit.site.cfg.py.in
+++ b/compiler-rt/test/ubsan_minimal/lit.site.cfg.py.in
@@ -1,5 +1,7 @@
 @LIT_SITE_CFG_IN_HEADER@
 
+config.name_suffix = "@UBSAN_TEST_CONFIG_SUFFIX@"
+
 # Tool-specific config options.
 config.target_cflags = "@UBSAN_TEST_TARGET_CFLAGS@"
 config.target_arch = "@UBSAN_TEST_TARGET_ARCH@"



More information about the llvm-commits mailing list