[compiler-rt] [TySan] Fix false positives with derived classes (PR #126260)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 24 08:28:14 PDT 2025


================
@@ -153,8 +143,50 @@ static bool isAliasingLegalUp(tysan_type_descriptor *TDA,
   return false;
 }
 
+static bool isAliasingLegalUp(tysan_type_descriptor *TDA,
+                              tysan_type_descriptor *TDB) {
+  // Walk up the tree starting with TDA to see if we reach TDB.
----------------
fhahn wrote:

Should the comment be moved outside function?
```suggestion
// Walk up the tree starting with TDA to see if we reach TDB.
static bool isAliasingLegalUp(tysan_type_descriptor *TDA,
                              tysan_type_descriptor *TDB) {
```

https://github.com/llvm/llvm-project/pull/126260


More information about the llvm-commits mailing list