[llvm] [NVPTX] Small NVVMReflect bug (PR #137062)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 23 14:21:49 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-nvptx
Author: Yonah Goldberg (YonahGoldberg)
<details>
<summary>Changes</summary>
I noticed a small bug I introduced in the NVVMReflect pass. The `Changed` variable should be initialized to false, because by default the pass doesn't modify the IR.
---
Full diff: https://github.com/llvm/llvm-project/pull/137062.diff
1 Files Affected:
- (modified) llvm/lib/Target/NVPTX/NVVMReflect.cpp (+1-1)
``````````diff
diff --git a/llvm/lib/Target/NVPTX/NVVMReflect.cpp b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
index 208bab52284a3..5ba4819afcdb5 100644
--- a/llvm/lib/Target/NVPTX/NVVMReflect.cpp
+++ b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
@@ -217,7 +217,7 @@ bool NVVMReflect::runOnModule(Module &M) {
if (!NVVMReflectEnabled)
return false;
populateReflectMap(M);
- bool Changed = true;
+ bool Changed = false;
Changed |= handleReflectFunction(M, NVVM_REFLECT_FUNCTION);
Changed |= handleReflectFunction(M, NVVM_REFLECT_OCL_FUNCTION);
Changed |=
``````````
</details>
https://github.com/llvm/llvm-project/pull/137062
More information about the llvm-commits
mailing list