[llvm] [NVPTX] Small NVVMReflect bug (PR #137062)

Yonah Goldberg via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 23 14:21:13 PDT 2025


https://github.com/YonahGoldberg created https://github.com/llvm/llvm-project/pull/137062

I noticed a small bug I introduced in the NVVMReflect pass. The `Changed` variable should be initialized to false, because by default the pass doesn't modify the IR.

>From 54febd2f74df041eb2a54690d9a597331a5e4e0a Mon Sep 17 00:00:00 2001
From: Yonah Goldberg <ygoldberg at nvidia.com>
Date: Wed, 23 Apr 2025 21:16:43 +0000
Subject: [PATCH] fixing a small bug

---
 llvm/lib/Target/NVPTX/NVVMReflect.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/lib/Target/NVPTX/NVVMReflect.cpp b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
index 208bab52284a3..5ba4819afcdb5 100644
--- a/llvm/lib/Target/NVPTX/NVVMReflect.cpp
+++ b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
@@ -217,7 +217,7 @@ bool NVVMReflect::runOnModule(Module &M) {
   if (!NVVMReflectEnabled)
     return false;
   populateReflectMap(M);
-  bool Changed = true;
+  bool Changed = false;
   Changed |= handleReflectFunction(M, NVVM_REFLECT_FUNCTION);
   Changed |= handleReflectFunction(M, NVVM_REFLECT_OCL_FUNCTION);
   Changed |=



More information about the llvm-commits mailing list