[llvm] [llvm] annotate interfaces in llvm/Support for DLL export (PR #136014)

[Nikita Popov via llvm-commits]

nikic wrote:

Thanks, that's very useful! TBH, I didn't expect that there would be *that* much cleanup afterwards. I understand some of it (e.g. code under different macros), but some of this feels like it shouldn't require manual fixup.

For example, are there ever cases where we *don't* want to add LLVM_ABI on classes with virtual methods?

Though I can't say I really get under which circumstances we need LLVM_ABI on the class for non-virtual cases. E.g. why do we need it on StringSaver?

https://github.com/llvm/llvm-project/pull/136014