[llvm] [SPIRV] Change how to detect OpenCL/Vulkan Env and update tests accordingly. (PR #129689)
Marcos Maronas via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 23 04:15:53 PDT 2025
maarquitos14 wrote:
@Keenuts the new approach I just added makes 58 tests fail. They can all pass if we explicitly pass `vulkan` in the triple. I didn't look at all of them individually, but took a look at a handful of them and from my POV, there's not enough information to make them work with `unknown-unknown` triple. In other words, I don't see anything Shader/Vulkan specific in them so that we can infer from the module what's the environment. Therefore, I think the only way to make them pass would be explicitly setting the triple to include `vulkan`. What do you think? Is that acceptable?
https://github.com/llvm/llvm-project/pull/129689
More information about the llvm-commits
mailing list