[llvm] [CostModel] Remove optional from InstructionCost::getValue() (PR #135596)

Tue Apr 22 23:54:36 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ml-opt-devrel-x86-64` running on `ml-opt-devrel-x86-64-b2` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/17328

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
114.641 [1495/40/2325] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanSLP.cpp.o
114.804 [1495/39/2326] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/SandboxVectorizer/Passes/BottomUpVec.cpp.o
In file included from /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/Passes/BottomUpVec.h:21,
                 from /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Transforms/Vectorize/SandboxVectorizer/Passes/BottomUpVec.cpp:9:
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/Legality.h:185:33: warning: ‘maybe_unused’ attribute ignored [-Wattributes]
  185 |   [[maybe_unused]] ResultReason Reason;
      |                                 ^~~~~~
114.980 [1495/38/2327] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanConstruction.cpp.o
115.092 [1495/37/2328] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanAnalysis.cpp.o
115.391 [1495/36/2329] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineSizeEstimatorAnalysis.cpp.o
FAILED: lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineSizeEstimatorAnalysis.cpp.o 
ccache /usr/bin/c++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DGTEST_HAS_RTTI=0 -DHAS_LOGF128 -DLLVM_HAVE_TF_AOT_INLINERSIZEMODEL -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-devrel-x86-64-b1/build/lib/Analysis -I/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis -I/var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include -I/b/ml-opt-devrel-x86-64-b1/build/include -I/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/include -isystem /tmp/tflitebuild/tensorflow/include -isystem /tmp/tflitebuild/eigen/include/eigen3 -isystem /tmp/tflitebuild/abseil-cpp/include -isystem /tmp/tflitebuild/flatbuffers/include -isystem /tmp/tflitebuild/gemmlowp/include/gemmlowp -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes/ml_dtypes -isystem /tmp/tflitebuild/ruy/include -isystem /tmp/tflitebuild/cpuinfo/include -isystem /tmp/tflitebuild/ARM_NEON_2_x86_SSE/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -DEIGEN_NEON_GEBP_NR=4 -DTFL_STATIC_LIBRARY_BUILD -std=c++17 -MD -MT lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineSizeEstimatorAnalysis.cpp.o -MF lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineSizeEstimatorAnalysis.cpp.o.d -o lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineSizeEstimatorAnalysis.cpp.o -c /b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/InlineSizeEstimatorAnalysis.cpp
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/InlineSizeEstimatorAnalysis.cpp: In function ‘size_t {anonymous}::getSize(llvm::Function&, llvm::TargetTransformInfo&)’:
/b/ml-opt-devrel-x86-64-b1/llvm-project/llvm/lib/Analysis/InlineSizeEstimatorAnalysis.cpp:131:14: error: invalid type argument of unary ‘*’ (have ‘llvm::InstructionCost::CostType’ {aka ‘long int’})
  131 |       Ret += *(TTI.getInstructionCost(
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~
  132 |           &I, TargetTransformInfo::TargetCostKind::TCK_CodeSize).getValue());
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
115.401 [1495/35/2330] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/LoopVectorizationLegality.cpp.o
115.832 [1495/34/2331] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/GlobalOpt.cpp.o
116.201 [1495/33/2332] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/LoadStoreVectorizer.cpp.o
116.269 [1495/32/2333] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanUnroll.cpp.o
116.694 [1495/31/2334] Building CXX object lib/Target/CMakeFiles/LLVMTarget.dir/TargetMachineC.cpp.o
116.723 [1495/30/2335] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/KernelInfo.cpp.o
116.735 [1495/29/2336] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineAdvisor.cpp.o
118.534 [1495/28/2337] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/LoopCacheAnalysis.cpp.o
118.601 [1495/27/2338] Building CXX object lib/Transforms/InstCombine/CMakeFiles/LLVMInstCombine.dir/InstructionCombining.cpp.o
118.942 [1495/26/2339] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/UniformityAnalysis.cpp.o
119.260 [1495/25/2340] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineOrder.cpp.o
119.391 [1495/24/2341] Building CXX object lib/Target/CMakeFiles/LLVMTarget.dir/TargetMachine.cpp.o
119.758 [1495/23/2342] Building CXX object lib/Transforms/Utils/CMakeFiles/LLVMTransformUtils.dir/SimplifyCFG.cpp.o
119.818 [1495/22/2343] Building CXX object lib/Transforms/IPO/CMakeFiles/LLVMipo.dir/IROutliner.cpp.o
120.193 [1495/21/2344] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/LoopStrengthReduce.cpp.o
120.673 [1495/20/2345] Building CXX object lib/SandboxIR/CMakeFiles/LLVMSandboxIR.dir/Region.cpp.o
120.675 [1495/19/2346] Building CXX object lib/Transforms/Coroutines/CMakeFiles/LLVMCoroutines.dir/CoroFrame.cpp.o
121.245 [1495/18/2347] Building CXX object lib/Transforms/Coroutines/CMakeFiles/LLVMCoroutines.dir/CoroSplit.cpp.o
121.362 [1495/17/2348] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VectorCombine.cpp.o
121.569 [1495/16/2349] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/TargetTransformInfo.cpp.o
121.619 [1495/15/2350] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlan.cpp.o
121.832 [1495/14/2351] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/InlineCost.cpp.o
122.393 [1495/13/2352] Building CXX object lib/Transforms/Vectorize/CMakeFiles/LLVMVectorize.dir/VPlanRecipes.cpp.o
123.258 [1495/12/2353] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/VectorUtils.cpp.o
123.353 [1495/11/2354] Building CXX object lib/Transforms/Scalar/CMakeFiles/LLVMScalarOpts.dir/SimpleLoopUnswitch.cpp.o
124.252 [1495/10/2355] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/MLInlineAdvisor.cpp.o
In file included from /var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include/absl/hash/internal/hash.h:53,
                 from /var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include/absl/hash/hash.h:85,
                 from /var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include/absl/container/internal/hash_function_defaults.h:55,
                 from /var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include/absl/container/flat_hash_map.h:41,
                 from /var/lib/buildbot/.local/lib/python3.7/site-packages/tensorflow/include/xla/executable_run_options.h:24,

```

</details>

https://github.com/llvm/llvm-project/pull/135596