[llvm] [AMDGPU][Verifier] Check address space of `alloca` instruction (PR #135820)

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 22 13:47:21 PDT 2025


================
@@ -4395,6 +4395,11 @@ void Verifier::visitAllocaInst(AllocaInst &AI) {
     verifySwiftErrorValue(&AI);
   }
 
+  if (TT.isAMDGPU()) {
----------------
shiltian wrote:

Looking at the code in `Verifier.cpp`, it has many target specific logic there, so I guess it should be fine. On the other hand, there are also arguments suggesting that it is fine to have **some** target dependent check here (https://github.com/llvm/llvm-project/pull/123609#issuecomment-2822352064).

https://github.com/llvm/llvm-project/pull/135820


More information about the llvm-commits mailing list