[llvm] [HLSL] Analyze updateCounter usage (PR #135669)

[Helena Kotas via llvm-commits]

================
@@ -463,7 +463,7 @@ class DXILResourceMap {
   /// ambiguous so multiple creation instructions may be returned. The resulting
   /// ResourceInfo can be used to depuplicate unique handles that
   /// reference the same resource
-  SmallVector<dxil::ResourceInfo> findByUse(const Value *Key) const;
+  SmallVector<dxil::ResourceInfo *> findByUse(const Value *Key);
----------------
hekota wrote:

> Now that setting the value is internal to the analysis, it might make sense to make this an internal/static function? Feels a bit strange to leave the non-const function in the public api.
> 
> Thoughts?

I agree - it should be a private or a static function if it does not need to be exposed to other users.

https://github.com/llvm/llvm-project/pull/135669