[lld] [lld] NFC. Rename function to better reflect their implementation (PR #136625)

Pranav Kant via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 21 15:28:01 PDT 2025


https://github.com/pranavk updated https://github.com/llvm/llvm-project/pull/136625

>From 934a16b96751aa17636b5f73d402921493befeaf Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Mon, 21 Apr 2025 22:21:08 +0000
Subject: [PATCH 1/2] [lld] NFC. Rename function to better reflect their
 implementation

---
 lld/ELF/ICF.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lld/ELF/ICF.cpp b/lld/ELF/ICF.cpp
index 849f6bdd445f9..fe18acc9bc5d9 100644
--- a/lld/ELF/ICF.cpp
+++ b/lld/ELF/ICF.cpp
@@ -120,7 +120,7 @@ template <class ELFT> class ICF {
   void forEachClassRange(size_t begin, size_t end,
                          llvm::function_ref<void(size_t, size_t)> fn);
 
-  void forEachClass(llvm::function_ref<void(size_t, size_t)> fn);
+  void parallelForEachClass(llvm::function_ref<void(size_t, size_t)> fn);
 
   Ctx &ctx;
   SmallVector<InputSection *, 0> sections;
@@ -433,7 +433,7 @@ void ICF<ELFT>::forEachClassRange(size_t begin, size_t end,
 
 // Call Fn on each equivalence class.
 template <class ELFT>
-void ICF<ELFT>::forEachClass(llvm::function_ref<void(size_t, size_t)> fn) {
+void ICF<ELFT>::parallelForEachClass(llvm::function_ref<void(size_t, size_t)> fn) {
   // If threading is disabled or the number of sections are
   // too small to use threading, call Fn sequentially.
   if (parallel::strategy.ThreadsRequested == 1 || sections.size() < 1024) {
@@ -541,14 +541,14 @@ template <class ELFT> void ICF<ELFT>::run() {
   // static content. Use a base offset for these IDs to ensure no overlap with
   // the unique IDs already assigned.
   uint32_t eqClassBase = ++uniqueId;
-  forEachClass([&](size_t begin, size_t end) {
+  parallelForEachClass([&](size_t begin, size_t end) {
     segregate(begin, end, eqClassBase, true);
   });
 
   // Split groups by comparing relocations until convergence is obtained.
   do {
     repeat = false;
-    forEachClass([&](size_t begin, size_t end) {
+    parallelForEachClass([&](size_t begin, size_t end) {
       segregate(begin, end, eqClassBase, false);
     });
   } while (repeat);

>From ca5f151d262ba97e844852a69765d1be560c990f Mon Sep 17 00:00:00 2001
From: Pranav Kant <prka at google.com>
Date: Mon, 21 Apr 2025 22:27:42 +0000
Subject: [PATCH 2/2] clang-format

---
 lld/ELF/ICF.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lld/ELF/ICF.cpp b/lld/ELF/ICF.cpp
index fe18acc9bc5d9..1882116d4d5f0 100644
--- a/lld/ELF/ICF.cpp
+++ b/lld/ELF/ICF.cpp
@@ -432,8 +432,10 @@ void ICF<ELFT>::forEachClassRange(size_t begin, size_t end,
 }
 
 // Call Fn on each equivalence class.
+
 template <class ELFT>
-void ICF<ELFT>::parallelForEachClass(llvm::function_ref<void(size_t, size_t)> fn) {
+void ICF<ELFT>::parallelForEachClass(
+    llvm::function_ref<void(size_t, size_t)> fn) {
   // If threading is disabled or the number of sections are
   // too small to use threading, call Fn sequentially.
   if (parallel::strategy.ThreadsRequested == 1 || sections.size() < 1024) {



More information about the llvm-commits mailing list