[llvm] [mlir] Emitc.convert (PR #136621)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 21 14:52:33 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- mlir/include/mlir/Conversion/ConvertToEmitC/ConvertToEmitCPass.h mlir/include/mlir/Conversion/ConvertToEmitC/ToEmitCInterface.h mlir/lib/Conversion/ConvertToEmitC/ConvertToEmitCPass.cpp mlir/include/mlir/Conversion/ArithToEmitC/ArithToEmitC.h mlir/include/mlir/Conversion/FuncToEmitC/FuncToEmitC.h mlir/include/mlir/Conversion/MemRefToEmitC/MemRefToEmitC.h mlir/include/mlir/Conversion/Passes.h mlir/include/mlir/Conversion/SCFToEmitC/SCFToEmitC.h mlir/include/mlir/InitAllExtensions.h mlir/lib/Conversion/ArithToEmitC/ArithToEmitC.cpp mlir/lib/Conversion/FuncToEmitC/FuncToEmitC.cpp mlir/lib/Conversion/FuncToEmitC/FuncToEmitCPass.cpp mlir/lib/Conversion/MemRefToEmitC/MemRefToEmitC.cpp mlir/lib/Conversion/MemRefToEmitC/MemRefToEmitCPass.cpp mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp mlir/lib/Dialect/Arith/IR/ArithDialect.cpp mlir/lib/Dialect/EmitC/IR/EmitC.cpp mlir/lib/Dialect/Func/IR/FuncOps.cpp mlir/lib/Dialect/MemRef/IR/MemRefDialect.cpp mlir/lib/Dialect/SCF/IR/SCF.cpp mlir/lib/Target/Cpp/TranslateToCpp.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/mlir/lib/Target/Cpp/TranslateToCpp.cpp b/mlir/lib/Target/Cpp/TranslateToCpp.cpp
index d34c1dbf6..7b0212196 100644
--- a/mlir/lib/Target/Cpp/TranslateToCpp.cpp
+++ b/mlir/lib/Target/Cpp/TranslateToCpp.cpp
@@ -1143,14 +1143,14 @@ static LogicalResult printOperation(CppEmitter &emitter,
raw_indented_ostream &os = emitter.ostream();
os << "class MyClass final {\n";
auto argAttrs = functionOp.getArgAttrs();
-
+
std::map<std::string, Value> fields;
if (argAttrs)
- for (auto [a,v] : zip(*argAttrs, functionOp.getArguments())) {
+ for (auto [a, v] : zip(*argAttrs, functionOp.getArguments())) {
if (auto da = dyn_cast<mlir::DictionaryAttr>(a)) {
auto name = cast<mlir::StringAttr>(
- da.getNamed("ml_program.identifier")->getValue())
- .str();
+ da.getNamed("ml_program.identifier")->getValue())
+ .str();
fields[name] = v;
os << " ";
if (failed(emitter.emitType(functionOp.getLoc(), v.getType())))
@@ -1159,15 +1159,16 @@ static LogicalResult printOperation(CppEmitter &emitter,
}
}
os << " std::map<std::string, char*> _buffer_map {";
- for (auto &[n,v]:fields)
- os << "{ \"" << n << "\"" << ", reinterpret_cast<char*>(" << emitter.getOrCreateName(v) << ") },";
+ for (auto &[n, v] : fields)
+ os << "{ \"" << n << "\"" << ", reinterpret_cast<char*>("
+ << emitter.getOrCreateName(v) << ") },";
os << " };\n";
os << " char* getBufferForName(const std::string& name) const {\n";
os << " auto it = _buffer_map.find(name);\n";
os << " return (it == _buffer_map.end()) ? nullptr : it->second;\n";
os << " }\n";
CppEmitter::Scope scope(emitter);
-
+
if (functionOp.getSpecifiers()) {
for (Attribute specifier : functionOp.getSpecifiersAttr()) {
os << cast<StringAttr>(specifier).str() << " ";
@@ -1188,7 +1189,8 @@ static LogicalResult printOperation(CppEmitter &emitter,
os << ");";
return success();
}
- // if (failed(printFunctionArgs(emitter, operation, functionOp.getArguments())))
+ // if (failed(printFunctionArgs(emitter, operation,
+ // functionOp.getArguments())))
// return failure();
os << ") {\n";
if (failed(printFunctionBody(emitter, operation, functionOp.getBlocks())))
``````````
</details>
https://github.com/llvm/llvm-project/pull/136621
More information about the llvm-commits
mailing list