[llvm] [RISCV] Report error if Zilsd is used on RV32. (PR #136577)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 21 09:30:36 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-risc-v
Author: Craig Topper (topperc)
<details>
<summary>Changes</summary>
Fixes #<!-- -->136564.
---
Full diff: https://github.com/llvm/llvm-project/pull/136577.diff
2 Files Affected:
- (modified) llvm/lib/TargetParser/RISCVISAInfo.cpp (+3)
- (modified) llvm/unittests/TargetParser/RISCVISAInfoTest.cpp (+10)
``````````diff
diff --git a/llvm/lib/TargetParser/RISCVISAInfo.cpp b/llvm/lib/TargetParser/RISCVISAInfo.cpp
index 524d6dc01e8aa..1e7144ce6d22b 100644
--- a/llvm/lib/TargetParser/RISCVISAInfo.cpp
+++ b/llvm/lib/TargetParser/RISCVISAInfo.cpp
@@ -789,6 +789,9 @@ Error RISCVISAInfo::checkDependency() {
return getIncompatibleError("zclsd", "zcf");
}
+ if (XLen != 32 && Exts.count("zilsd") != 0)
+ return getError("'zilsd' is only supported for 'rv32'");
+
for (auto Ext : XqciExts)
if (Exts.count(Ext.str()) && (XLen != 32))
return getError("'" + Twine(Ext) + "'" + " is only supported for 'rv32'");
diff --git a/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp b/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
index ff0a5e64ab3e1..6e190ad3e7969 100644
--- a/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
+++ b/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
@@ -658,6 +658,16 @@ TEST(ParseArchString, RejectsConflictingExtensions) {
"'xwchc' and 'zcb' extensions are incompatible");
}
+ for (StringRef Input : {"rv64i_zilsd"}) {
+ EXPECT_EQ(toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
+ "'zilsd' is only supported for 'rv32'");
+ }
+
+ for (StringRef Input : {"rv64i_zclsd"}) {
+ EXPECT_EQ(toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
+ "'zclsd' is only supported for 'rv32'");
+ }
+
for (StringRef Input : {"rv32i_zcf_zclsd"}) {
EXPECT_EQ(toString(RISCVISAInfo::parseArchString(Input, true).takeError()),
"'zclsd' and 'zcf' extensions are incompatible");
``````````
</details>
https://github.com/llvm/llvm-project/pull/136577
More information about the llvm-commits
mailing list