[llvm] [AMDGPU] Fix register class constraints for si-fold-operands pass when folding immediate into copies (PR #131387)
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 18 12:42:36 PDT 2025
================
@@ -1068,6 +1068,20 @@ void SIFoldOperandsImpl::foldOperand(
if (MovOp == AMDGPU::COPY)
return;
+ // Check for common register subclass between destination (DestRC) and MOV
+ // result (ResRC). If exists, verify this common subclass is a superclass of
+ // (or equal to) the destination register class, otherwise folding is
+ // illegal.
+
+ const MCInstrDesc &MovDesc = TII->get(MovOp);
+ assert(MovDesc.getNumDefs() > 0 && MovDesc.operands()[0].RegClass != -1);
+ const TargetRegisterClass *ResRC =
+ TRI->getRegClass(MovDesc.operands()[0].RegClass);
+ const TargetRegisterClass *CommonRC = TRI->getCommonSubClass(DestRC, ResRC);
+
+ if (!CommonRC || !DestRC->hasSuperClassEq(CommonRC))
+ return;
+
----------------
arsenm wrote:
```suggestion
if (!CommonRC)
return;
```
hasSuperClassEq should be redundant with finding the common class
https://github.com/llvm/llvm-project/pull/131387
More information about the llvm-commits
mailing list