[llvm] [DirectX] Implement the DXILCBufferAccess pass (PR #134571)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 6 20:38:37 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/Frontend/HLSL/CBuffer.h llvm/lib/Frontend/HLSL/CBuffer.cpp llvm/lib/Target/DirectX/DXILCBufferAccess.cpp llvm/lib/Target/DirectX/DXILCBufferAccess.h llvm/lib/Target/DirectX/DirectX.h llvm/lib/Target/DirectX/DirectXTargetMachine.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Frontend/HLSL/CBuffer.cpp b/llvm/lib/Frontend/HLSL/CBuffer.cpp
index b311f6aea..db1003ad3 100644
--- a/llvm/lib/Frontend/HLSL/CBuffer.cpp
+++ b/llvm/lib/Frontend/HLSL/CBuffer.cpp
@@ -57,7 +57,6 @@ std::optional<CBufferMetadata> CBufferMetadata::get(Module &M) {
return Result;
}
-
void CBufferMetadata::eraseFromModule() {
// Remove the cbs named metadata
MD->eraseFromParent();
diff --git a/llvm/lib/Target/DirectX/DXILCBufferAccess.cpp b/llvm/lib/Target/DirectX/DXILCBufferAccess.cpp
index f8771efea..3867502e7 100644
--- a/llvm/lib/Target/DirectX/DXILCBufferAccess.cpp
+++ b/llvm/lib/Target/DirectX/DXILCBufferAccess.cpp
@@ -50,7 +50,7 @@ struct CBufferRowIntrin {
break;
default:
llvm_unreachable("Only 16, 32, and 64 bit types supported");
- }
+ }
}
};
} // namespace
@@ -190,9 +190,7 @@ PreservedAnalyses DXILCBufferAccess::run(Module &M, ModuleAnalysisManager &AM) {
namespace {
class DXILCBufferAccessLegacy : public ModulePass {
public:
- bool runOnModule(Module &M) override {
- return replaceCBufferAccesses(M);
- }
+ bool runOnModule(Module &M) override { return replaceCBufferAccesses(M); }
StringRef getPassName() const override { return "DXIL CBuffer Access"; }
DXILCBufferAccessLegacy() : ModulePass(ID) {}
``````````
</details>
https://github.com/llvm/llvm-project/pull/134571
More information about the llvm-commits
mailing list