[clang] [llvm] [LLVM][Clang][Cygwin] Fix Cygwin builds (PR #134458)

[via llvm-commits]

Mateusz =?utf-8?q?Mikuła?= <oss at mateuszmikula.dev>,
Mateusz =?utf-8?q?Mikuła?= <oss at mateuszmikula.dev>,
Mateusz =?utf-8?q?Mikuła?= <oss at mateuszmikula.dev>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/134458 at github.com>


================
@@ -236,8 +236,7 @@ class ItaniumCXXABI : public CXXABI {
 
   CallingConv getDefaultMethodCallConv(bool isVariadic) const override {
     const llvm::Triple &T = Context.getTargetInfo().getTriple();
-    if (!isVariadic && T.isWindowsGNUEnvironment() &&
-        T.getArch() == llvm::Triple::x86)
+    if (!isVariadic && T.isOSCygMing() && T.getArch() == llvm::Triple::x86)
----------------
jeremyd2019 wrote:

I know this PR is closed, but for the record: this particular change appears to be wrong: on i686 cygwin with this change calls to libstdc++ basic_string::_M_assign crashed, but with this change backed out it's much happier.

https://github.com/llvm/llvm-project/pull/134458