[llvm] 590d2a3 - [Mips, MC] Replace getSymA()->getSymbol() with getAddSym. NFC

[Fangrui Song via llvm-commits]

Author: Fangrui Song
Date: 2025-04-05T14:25:06-07:00
New Revision: 590d2a3ca5fde93aff1ef1611f1361180adb1813

URL: https://github.com/llvm/llvm-project/commit/590d2a3ca5fde93aff1ef1611f1361180adb1813
DIFF: https://github.com/llvm/llvm-project/commit/590d2a3ca5fde93aff1ef1611f1361180adb1813.diff

LOG: [Mips,MC] Replace getSymA()->getSymbol() with getAddSym. NFC

We will replace the MCSymbolRefExpr member in MCValue with MCSymbol.
This change reduces dependence on MCSymbolRefExpr.

Added: 
    

Modified: 
    llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp b/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
index b6d71f27c1272..c9957c2881111 100644
--- a/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
+++ b/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
@@ -81,16 +81,16 @@ bool AVRMCExpr::evaluateAsRelocatableImpl(MCValue &Result,
       return false;
 
     MCContext &Context = Asm->getContext();
-    const MCSymbolRefExpr *Sym = Value.getSymA();
-    MCSymbolRefExpr::VariantKind Modifier = Sym->getKind();
-    if (Modifier != MCSymbolRefExpr::VK_None)
+    const MCSymbolRefExpr *Sym = nullptr;
+    auto Spec = AVRMCExpr::VK_None;
+    if (Value.getSymSpecifier() != MCSymbolRefExpr::VK_None)
       return false;
     assert(!Value.getSubSym());
-    if (specifier == VK_PM) {
-      Modifier = MCSymbolRefExpr::VariantKind(AVRMCExpr::VK_PM);
-    }
+    if (specifier == VK_PM)
+      Spec = AVRMCExpr::VK_PM;
 
-    Sym = MCSymbolRefExpr::create(&Sym->getSymbol(), Modifier, Context);
+    // TODO: don't attach specifier to MCSymbolRefExpr.
+    Sym = MCSymbolRefExpr::create(Value.getAddSym(), Spec, Context);
     Result = MCValue::get(Sym, nullptr, Value.getConstant());
   }