[llvm] 0431fea - [AMDGPU,MC] Replace getSymA()->getSymbol() with getAddSym. NFC
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 5 14:04:05 PDT 2025
Author: Fangrui Song
Date: 2025-04-05T14:04:00-07:00
New Revision: 0431fea88ac9a057d1c8751da7f9506cf51f54c5
URL: https://github.com/llvm/llvm-project/commit/0431fea88ac9a057d1c8751da7f9506cf51f54c5
DIFF: https://github.com/llvm/llvm-project/commit/0431fea88ac9a057d1c8751da7f9506cf51f54c5.diff
LOG: [AMDGPU,MC] Replace getSymA()->getSymbol() with getAddSym. NFC
We will replace the MCSymbolRefExpr member in MCValue with MCSymbol.
This change reduces dependence on MCSymbolRefExpr.
Added:
Modified:
llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp
index 50531af627e4a..bf27688e3b221 100644
--- a/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp
+++ b/llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFObjectWriter.cpp
@@ -38,11 +38,11 @@ unsigned AMDGPUELFObjectWriter::getRelocType(MCContext &Ctx,
const MCValue &Target,
const MCFixup &Fixup,
bool IsPCRel) const {
- if (const auto *SymA = Target.getSymA()) {
+ if (const auto *SymA = Target.getAddSym()) {
// SCRATCH_RSRC_DWORD[01] is a special global variable that represents
// the scratch buffer.
- if (SymA->getSymbol().getName() == "SCRATCH_RSRC_DWORD0" ||
- SymA->getSymbol().getName() == "SCRATCH_RSRC_DWORD1")
+ if (SymA->getName() == "SCRATCH_RSRC_DWORD0" ||
+ SymA->getName() == "SCRATCH_RSRC_DWORD1")
return ELF::R_AMDGPU_ABS32_LO;
}
@@ -82,12 +82,12 @@ unsigned AMDGPUELFObjectWriter::getRelocType(MCContext &Ctx,
}
if (Fixup.getTargetKind() == AMDGPU::fixup_si_sopp_br) {
- const auto *SymA = Target.getSymA();
+ const auto *SymA = Target.getAddSym();
assert(SymA);
- if (SymA->getSymbol().isUndefined()) {
- Ctx.reportError(Fixup.getLoc(), Twine("undefined label '") +
- SymA->getSymbol().getName() + "'");
+ if (SymA->isUndefined()) {
+ Ctx.reportError(Fixup.getLoc(),
+ Twine("undefined label '") + SymA->getName() + "'");
return ELF::R_AMDGPU_NONE;
}
return ELF::R_AMDGPU_REL16;
More information about the llvm-commits
mailing list