[llvm] cadfaa8 - [AVR,CSKY] Migrate away from MCValue::getSymB
Fangrui Song via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 5 11:45:58 PDT 2025
Author: Fangrui Song
Date: 2025-04-05T11:45:53-07:00
New Revision: cadfaa83ff1f7d9f983b23a756f25884a3d6314c
URL: https://github.com/llvm/llvm-project/commit/cadfaa83ff1f7d9f983b23a756f25884a3d6314c
DIFF: https://github.com/llvm/llvm-project/commit/cadfaa83ff1f7d9f983b23a756f25884a3d6314c.diff
LOG: [AVR,CSKY] Migrate away from MCValue::getSymB
The MCValue::SymB MCSymbolRefExpr member might be replaced with a
MCSymbol in the future. Reduce direct access.
Added:
Modified:
llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
llvm/lib/Target/CSKY/MCTargetDesc/CSKYMCExpr.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp b/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
index e187a825a5268..b6d71f27c1272 100644
--- a/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
+++ b/llvm/lib/Target/AVR/MCTargetDesc/AVRMCExpr.cpp
@@ -85,12 +85,13 @@ bool AVRMCExpr::evaluateAsRelocatableImpl(MCValue &Result,
MCSymbolRefExpr::VariantKind Modifier = Sym->getKind();
if (Modifier != MCSymbolRefExpr::VK_None)
return false;
+ assert(!Value.getSubSym());
if (specifier == VK_PM) {
Modifier = MCSymbolRefExpr::VariantKind(AVRMCExpr::VK_PM);
}
Sym = MCSymbolRefExpr::create(&Sym->getSymbol(), Modifier, Context);
- Result = MCValue::get(Sym, Value.getSymB(), Value.getConstant());
+ Result = MCValue::get(Sym, nullptr, Value.getConstant());
}
return true;
diff --git a/llvm/lib/Target/CSKY/MCTargetDesc/CSKYMCExpr.cpp b/llvm/lib/Target/CSKY/MCTargetDesc/CSKYMCExpr.cpp
index 338ac63d88241..696cd1daa035c 100644
--- a/llvm/lib/Target/CSKY/MCTargetDesc/CSKYMCExpr.cpp
+++ b/llvm/lib/Target/CSKY/MCTargetDesc/CSKYMCExpr.cpp
@@ -72,5 +72,5 @@ bool CSKYMCExpr::evaluateAsRelocatableImpl(MCValue &Res,
if (!getSubExpr()->evaluateAsRelocatable(Res, Asm))
return false;
Res.setSpecifier(specifier);
- return !Res.getSymB();
+ return !Res.getSubSym();
}
More information about the llvm-commits
mailing list