[llvm] [NFC][SPIRV] remove unimplemented function define for `selectCross` (PR #134478)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 4 20:45:56 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-spir-v
Author: Farzon Lotfi (farzonl)
<details>
<summary>Changes</summary>
- `selectCross` looks to be a function that had its implementation and usage removed but this define some how stuck around.
- this change removes the definition.
---
Full diff: https://github.com/llvm/llvm-project/pull/134478.diff
1 Files Affected:
- (modified) llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp (-2)
``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
index 946a295c2df25..662c38ca4ed28 100644
--- a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
@@ -183,8 +183,6 @@ class SPIRVInstructionSelector : public InstructionSelector {
bool selectCmp(Register ResVReg, const SPIRVType *ResType,
unsigned comparisonOpcode, MachineInstr &I) const;
- bool selectCross(Register ResVReg, const SPIRVType *ResType,
- MachineInstr &I) const;
bool selectDiscard(Register ResVReg, const SPIRVType *ResType,
MachineInstr &I) const;
``````````
</details>
https://github.com/llvm/llvm-project/pull/134478
More information about the llvm-commits
mailing list