[llvm] [NFC][LLVM][DirectX] Cleanup pass initialization for DirectX (PR #134419)
Rahul Joshi via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 4 11:54:48 PDT 2025
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/134419
>From 1bca572503a5df7c77786206a22da65d7550e836 Mon Sep 17 00:00:00 2001
From: Rahul Joshi <rjoshi at nvidia.com>
Date: Fri, 4 Apr 2025 10:16:12 -0700
Subject: [PATCH] [NFC][LLVM][DirectX] Cleanup pass initialization for DirectX
- Remove calls to pass initialization from pass constructors.
---
llvm/lib/Target/DirectX/DXContainerGlobals.cpp | 4 +---
llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp | 7 +------
llvm/lib/Target/DirectX/DirectXTargetMachine.cpp | 1 +
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/llvm/lib/Target/DirectX/DXContainerGlobals.cpp b/llvm/lib/Target/DirectX/DXContainerGlobals.cpp
index c7a130a1f9c8a..f5a78722558fe 100644
--- a/llvm/lib/Target/DirectX/DXContainerGlobals.cpp
+++ b/llvm/lib/Target/DirectX/DXContainerGlobals.cpp
@@ -51,9 +51,7 @@ class DXContainerGlobals : public llvm::ModulePass {
public:
static char ID; // Pass identification, replacement for typeid
- DXContainerGlobals() : ModulePass(ID) {
- initializeDXContainerGlobalsPass(*PassRegistry::getPassRegistry());
- }
+ DXContainerGlobals() : ModulePass(ID) {}
StringRef getPassName() const override {
return "DXContainer Global Emitter";
diff --git a/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp b/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp
index 4d1832f44bb63..9c100ba9a9cbf 100644
--- a/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp
+++ b/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp
@@ -262,13 +262,8 @@ class DXILPrettyPrinterLegacy : public llvm::ModulePass {
public:
static char ID;
- DXILPrettyPrinterLegacy() : ModulePass(ID), OS(dbgs()) {
- initializeDXILPrettyPrinterLegacyPass(*PassRegistry::getPassRegistry());
- }
- explicit DXILPrettyPrinterLegacy(raw_ostream &O) : ModulePass(ID), OS(O) {
- initializeDXILPrettyPrinterLegacyPass(*PassRegistry::getPassRegistry());
- }
+ explicit DXILPrettyPrinterLegacy(raw_ostream &O) : ModulePass(ID), OS(O) {}
StringRef getPassName() const override {
return "DXIL Metadata Pretty Printer";
diff --git a/llvm/lib/Target/DirectX/DirectXTargetMachine.cpp b/llvm/lib/Target/DirectX/DirectXTargetMachine.cpp
index ce408b4034f83..747e4b3eb9411 100644
--- a/llvm/lib/Target/DirectX/DirectXTargetMachine.cpp
+++ b/llvm/lib/Target/DirectX/DirectXTargetMachine.cpp
@@ -64,6 +64,7 @@ extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeDirectXTarget() {
initializeShaderFlagsAnalysisWrapperPass(*PR);
initializeRootSignatureAnalysisWrapperPass(*PR);
initializeDXILFinalizeLinkageLegacyPass(*PR);
+ initializeDXILPrettyPrinterLegacyPass(*PR);
}
class DXILTargetObjectFile : public TargetLoweringObjectFile {
More information about the llvm-commits
mailing list