[llvm] [llvm-reduce] Fix incorrectly ignored null MD in ReduceDIMetadata (PR #108541)

[Stephen Tozer via llvm-commits]

https://github.com/SLTozer updated https://github.com/llvm/llvm-project/pull/108541

>From 1fabbdbf4edf569d173cd3a2ce56df6c0054c308 Mon Sep 17 00:00:00 2001
From: Stephen Tozer <stephen.tozer at sony.com>
Date: Fri, 13 Sep 2024 12:39:00 +0100
Subject: [PATCH 1/2] [llvm-reduce] Fix incorrectly ignored null MD in
 ReduceDIMetadata

Commit c2e62c7 updated the ReduceDIMetadata pass to be able to remove
DIGlobalVariableExpressions from MDNode operands; it also accidentally
prevented null operands from being preserved, which results in an
assertion being triggered:
`Targets == NoChunksCounter.count() && "number of chunks changes when reducing"'

This patch allows us to correctly preserve null operands once again.
---
 llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp b/llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp
index 38352d6342d4f..fbad6f697584e 100644
--- a/llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp
+++ b/llvm/tools/llvm-reduce/deltas/ReduceDIMetadata.cpp
@@ -70,8 +70,8 @@ void identifyUninterestingMDNodes(Oracle &O, MDNodeList &MDs) {
           // Don't add uninteresting operands to the tuple.
           if (!O.shouldKeep())
             continue;
-        TN.push_back(Op);
       }
+      TN.push_back(Tup->getOperand(I));
     }
     if (TN.size() != Tup->getNumOperands())
       DbgNode->replaceOperandWith(OpIdx, DbgNode->get(DbgNode->getContext(), TN));

>From 35725f29abd07da91438686f0a66aa5ef9aa5c46 Mon Sep 17 00:00:00 2001
From: Stephen Tozer <stephen.tozer at sony.com>
Date: Fri, 4 Apr 2025 18:50:59 +0100
Subject: [PATCH 2/2] Add test

---
 .../llvm-reduce/108541-null-metadata-crash.ll | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 llvm/test/tools/llvm-reduce/108541-null-metadata-crash.ll

diff --git a/llvm/test/tools/llvm-reduce/108541-null-metadata-crash.ll b/llvm/test/tools/llvm-reduce/108541-null-metadata-crash.ll
new file mode 100644
index 0000000000000..9b5b6e7d95eac
--- /dev/null
+++ b/llvm/test/tools/llvm-reduce/108541-null-metadata-crash.ll
@@ -0,0 +1,50 @@
+; RUN: llvm-reduce %s -o %t --delta-passes=di-metadata --test FileCheck --test-arg %s --test-arg --input-file --abort-on-invalid-reduction
+; CHECK: , !dbg !11
+
+;; Tests for the bug fixed in PR#108541, where the presence of null metadata
+;; could result in a crash.
+
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define i1 @ham() {
+bb:
+  %call = call fastcc i32 @hoge()
+  ret i1 false
+}
+
+define fastcc i32 @hoge() {
+bb:
+  br i1 poison, label %bb1, label %bb2
+
+bb1:                                              ; preds = %bb
+  br i1 false, label %bb2, label %bb2, !dbg !11
+
+bb2:                                              ; preds = %bb1, %bb1, %bb
+  ret i32 0
+}
+
+!llvm.dbg.cu = !{!0}
+!llvm.module.flags = !{!10}
+
+!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, producer: "clang version 20.0.0git", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, retainedTypes: !2, globals: !2, imports: !3, splitDebugInlining: false, nameTableKind: None)
+!1 = !DIFile(filename: "108541-metadata-crash.cpp", directory: "/tmp")
+!2 = !{}
+!3 = !{!4}
+!4 = !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !5, entity: !6, file: !7, line: 134)
+!5 = !DINamespace(name: "std", scope: null)
+!6 = !DISubprogram(name: "abort", scope: !7, file: !7, line: 730, type: !8, flags: DIFlagPrototyped | DIFlagNoReturn, spFlags: DISPFlagOptimized)
+!7 = !DIFile(filename: "108541-metadata-crash.cpp", directory: "")
+!8 = !DISubroutineType(types: !9)
+!9 = !{null}
+!10 = !{i32 2, !"Debug Info Version", i32 3}
+!11 = !DILocation(line: 26, column: 11, scope: !12)
+!12 = distinct !DILexicalBlock(scope: !14, file: !13, line: 26, column: 11)
+!13 = !DIFile(filename: "108541-metadata-crash.cpp", directory: "/tmp")
+!14 = distinct !DILexicalBlock(scope: !15, file: !13, line: 25, column: 5)
+!15 = distinct !DILexicalBlock(scope: !16, file: !13, line: 24, column: 9)
+!16 = distinct !DILexicalBlock(scope: !17, file: !13, line: 14, column: 3)
+!17 = distinct !DILexicalBlock(scope: !18, file: !13, line: 13, column: 3)
+!18 = distinct !DILexicalBlock(scope: !19, file: !13, line: 13, column: 3)
+!19 = distinct !DISubprogram(name: "hoge", linkageName: "hoge", scope: !13, file: !13, line: 10, type: !20, scopeLine: 11, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagLocalToUnit | DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !2)
+!20 = distinct !DISubroutineType(types: !2)