[llvm] [JITLink][NFC] Guard functions used only for debug for `XCOFFLinkGraphBuilder` (PR #134413)

Henry Jiang via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 4 09:40:48 PDT 2025


https://github.com/mustartt created https://github.com/llvm/llvm-project/pull/134413

2 of the functions in `XCOFFGraphBuilder` are only for debugging. So we need to guard it to avoid warnings.

>From 06d3fc19b64bcd8d22aafea932c0188676627c7a Mon Sep 17 00:00:00 2001
From: Henry Jiang <henry.jiang1 at ibm.com>
Date: Fri, 4 Apr 2025 12:37:56 -0400
Subject: [PATCH] guard functions used only for debug

---
 llvm/lib/ExecutionEngine/JITLink/XCOFFLinkGraphBuilder.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/llvm/lib/ExecutionEngine/JITLink/XCOFFLinkGraphBuilder.cpp b/llvm/lib/ExecutionEngine/JITLink/XCOFFLinkGraphBuilder.cpp
index c2dae5e3e5443..21a4182606a2f 100644
--- a/llvm/lib/ExecutionEngine/JITLink/XCOFFLinkGraphBuilder.cpp
+++ b/llvm/lib/ExecutionEngine/JITLink/XCOFFLinkGraphBuilder.cpp
@@ -40,6 +40,7 @@ XCOFFLinkGraphBuilder::XCOFFLinkGraphBuilder(
           std::string(Obj.getFileName()), std::move(SSP), std::move(TT),
           std::move(Features), std::move(GetEdgeKindName))) {}
 
+#ifndef NDEBUG
 static llvm::StringRef getStorageClassString(XCOFF::StorageClass SC) {
   switch (SC) {
   case XCOFF::StorageClass::C_FILE:
@@ -144,6 +145,7 @@ static llvm::StringRef getStorageClassString(XCOFF::StorageClass SC) {
     return "C_TCSYM (Reserved)";
   }
 }
+#endif
 
 Error XCOFFLinkGraphBuilder::processSections() {
   LLVM_DEBUG(dbgs() << "  Creating graph sections...\n");
@@ -203,6 +205,7 @@ getXCOFFSymbolContainingSymbolRef(const object::XCOFFObjectFile &Obj,
   return object::XCOFFSymbolRef(DRI, &Obj);
 }
 
+#ifndef NDEBUG
 static void printSymbolEntry(raw_ostream &OS,
                              const object::XCOFFObjectFile &Obj,
                              const object::XCOFFSymbolRef &Sym) {
@@ -231,6 +234,7 @@ static void printSymbolEntry(raw_ostream &OS,
   }
   OS << "\n";
 }
+#endif
 
 Error XCOFFLinkGraphBuilder::processCsectsAndSymbols() {
   LLVM_DEBUG(dbgs() << "  Creating graph blocks and symbols...\n");



More information about the llvm-commits mailing list