[flang] [llvm] [Flang] [OpenMP] Add semantic checks for detach clause in task (PR #119172)

[Tom Eccles via llvm-commits]

================
@@ -3627,40 +3683,45 @@ void OmpStructureChecker::CheckIsVarPartOfAnotherVar(
     const parser::CharBlock &source, const parser::OmpObjectList &objList,
     llvm::StringRef clause) {
   for (const auto &ompObject : objList.v) {
-    common::visit(
-        common::visitors{
-            [&](const parser::Designator &designator) {
-              if (const auto *dataRef{
-                      std::get_if<parser::DataRef>(&designator.u)}) {
-                if (IsDataRefTypeParamInquiry(dataRef)) {
+    CheckIsVarPartOfAnotherVar(source, ompObject, clause);
+  }
+}
+
+void OmpStructureChecker::CheckIsVarPartOfAnotherVar(
----------------
tblah wrote:

Suggestion, feel free to ignore. I think this would be clearer
```suggestion
void OmpStructureChecker::CheckVarIsNotPartOfAnotherVar(
```

https://github.com/llvm/llvm-project/pull/119172