[llvm] [BOLT] Gadget scanner: Detect address materialization and arithmetics (PR #132540)

Anatoly Trosinenko via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 3 08:02:25 PDT 2025


================
@@ -587,6 +587,22 @@ class MCPlusBuilder {
     return getNoRegister();
   }
 
+  virtual MCPhysReg getSafelyMaterializedAddressReg(const MCInst &Inst) const {
+    llvm_unreachable("not implemented");
+    return getNoRegister();
+  }
----------------
atrosinenko wrote:

Added your first paragraph to the detailed description, thanks.

As far as I understand, it is probably better not to _start_ a doxygen comment with lists, so I mostly kept my first sentence as-is - just added a reference to `Inst` and dropped "or NoRegister otherwise" part as a corner case which is explained in the detailed description now.

https://github.com/llvm/llvm-project/pull/132540


More information about the llvm-commits mailing list