[llvm] [ADT] Make DenseMap::init() private (NFC) (PR #134229)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 3 03:46:17 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-adt
Author: Nikita Popov (nikic)
<details>
<summary>Changes</summary>
I believe this method was not supposed to be public, as it has additional preconditions (it will misbehave when called on a non-empty DenseMap).
The public API for this is reserve().
---
Full diff: https://github.com/llvm/llvm-project/pull/134229.diff
2 Files Affected:
- (modified) llvm/include/llvm/ADT/DenseMap.h (+10-10)
- (modified) llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp (+4-4)
``````````diff
diff --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index ea9ba6f47ac1a..bb99a41646b08 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -806,16 +806,6 @@ class DenseMap : public DenseMapBase<DenseMap<KeyT, ValueT, KeyInfoT, BucketT>,
}
}
- void init(unsigned InitNumEntries) {
- auto InitBuckets = BaseT::getMinBucketToReserveForEntries(InitNumEntries);
- if (allocateBuckets(InitBuckets)) {
- this->BaseT::initEmpty();
- } else {
- NumEntries = 0;
- NumTombstones = 0;
- }
- }
-
void grow(unsigned AtLeast) {
unsigned OldNumBuckets = NumBuckets;
BucketT *OldBuckets = Buckets;
@@ -878,6 +868,16 @@ class DenseMap : public DenseMapBase<DenseMap<KeyT, ValueT, KeyInfoT, BucketT>,
allocate_buffer(sizeof(BucketT) * NumBuckets, alignof(BucketT)));
return true;
}
+
+ void init(unsigned InitNumEntries) {
+ auto InitBuckets = BaseT::getMinBucketToReserveForEntries(InitNumEntries);
+ if (allocateBuckets(InitBuckets)) {
+ this->BaseT::initEmpty();
+ } else {
+ NumEntries = 0;
+ NumTombstones = 0;
+ }
+ }
};
template <typename KeyT, typename ValueT, unsigned InlineBuckets = 4,
diff --git a/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp b/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
index 272749f5574c6..8eb523e7d24c6 100644
--- a/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
+++ b/llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
@@ -897,8 +897,8 @@ class MemLocFragmentFill {
Worklist.push(RPONumber);
++RPONumber;
}
- LiveIn.init(RPONumber);
- LiveOut.init(RPONumber);
+ LiveIn.reserve(RPONumber);
+ LiveOut.reserve(RPONumber);
}
// Perform the traversal.
@@ -2318,8 +2318,8 @@ bool AssignmentTrackingLowering::run(FunctionVarLocsBuilder *FnVarLocsBuilder) {
Worklist.push(RPONumber);
++RPONumber;
}
- LiveIn.init(RPONumber);
- LiveOut.init(RPONumber);
+ LiveIn.reserve(RPONumber);
+ LiveOut.reserve(RPONumber);
}
// Perform the traversal.
``````````
</details>
https://github.com/llvm/llvm-project/pull/134229
More information about the llvm-commits
mailing list