[libc] [llvm] [libc] Implemented utimes (Issue #133953) (PR #134167)

[Michael Jones via llvm-commits]

================
@@ -0,0 +1,81 @@
+//===-- Unittests for utimes --------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+// temp file related stuff
+#include "src/fcntl/open.h"    // to open
+#include "src/unistd/close.h"  // to close
+#include "src/sys/stat/stat.h" // for info
+#include "src/unistd/unlink.h" // to delete
+// testing error handling
+#include "test/UnitTest/Test.h"
+#include "src/errno/libc_errno.h"           
+#include "test/UnitTest/ErrnoSetterMatcher.h"
+// dependencies for the tests themselves
+#include "hdr/types/struct_timeval.h"
+#include <cerrno>
+#include <fcntl.h>
+#include "hdr/fcntl_macros.h"
+// the utimes function
+#include "src/sys/time/utimes.h" 
+constexpr const char* TEST_FILE = "testdata/utimes.test"; 
+
+// SUCCESS: Takes a file and successfully updates 
+// its last access and modified times.
+TEST(LlvmLibcUtimesTest, ChangeTimesSpecific){
+  using LIBC_NAMESPACE::testing::ErrnoSetterMatcher::Succeeds;
+  
+  // make a dummy timeval struct
+  struct timeval times[2];
+  times[0].tv_sec = 54321;
+  times[0].tv_usec = 12345;
+  times[1].tv_sec = 43210;
+  times[1].tv_usec = 23456;
+  
+  // ensure utimes succeeds
+  ASSERT_THAT(LIBC_NAMESPACE::utimes(TEST_FILE, times), Succeeds(0));
+
+  // verify the times values against stat of the TEST_FILE
+  struct stat statbuf;
+  ASSERT_EQ(stat(TEST_FILE, &statbuf), 0);
----------------
michaelrj-google wrote:

this should use `LIBC_NAMESPACE::stat` instead of the version from the global namespace. That version is from the system's libc and is being pulled in through `fcnt.h`.

https://github.com/llvm/llvm-project/pull/134167