[llvm] 2b7fe90 - llvm-reduce: Avoid worklist in simplify-instruction (#134066)

[via llvm-commits]

Author: Matt Arsenault
Date: 2025-04-02T22:21:28+07:00
New Revision: 2b7fe90a016ed402a1e52d4e13b6112c206369ea

URL: https://github.com/llvm/llvm-project/commit/2b7fe90a016ed402a1e52d4e13b6112c206369ea
DIFF: https://github.com/llvm/llvm-project/commit/2b7fe90a016ed402a1e52d4e13b6112c206369ea.diff

LOG: llvm-reduce: Avoid worklist in simplify-instruction (#134066)

Added: 
    

Modified: 
    llvm/tools/llvm-reduce/deltas/SimplifyInstructions.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-reduce/deltas/SimplifyInstructions.cpp b/llvm/tools/llvm-reduce/deltas/SimplifyInstructions.cpp
index 7eb381d3c1905..ee92b7fb88731 100644
--- a/llvm/tools/llvm-reduce/deltas/SimplifyInstructions.cpp
+++ b/llvm/tools/llvm-reduce/deltas/SimplifyInstructions.cpp
@@ -20,27 +20,20 @@ using namespace llvm;
 /// Calls simplifyInstruction in each instruction in functions, and replaces
 /// their values.
 void llvm::simplifyInstructionsDeltaPass(Oracle &O, ReducerWorkItem &WorkItem) {
-  std::vector<Instruction *> InstsToDelete;
-
   Module &Program = WorkItem.getModule();
   const DataLayout &DL = Program.getDataLayout();
 
-  std::vector<Instruction *> InstToDelete;
   for (auto &F : Program) {
     for (auto &BB : F) {
-      for (auto &Inst : BB) {
-
+      for (auto &Inst : make_early_inc_range(BB)) {
         SimplifyQuery Q(DL, &Inst);
         if (Value *Simplified = simplifyInstruction(&Inst, Q)) {
           if (O.shouldKeep())
             continue;
           Inst.replaceAllUsesWith(Simplified);
-          InstToDelete.push_back(&Inst);
+          Inst.eraseFromParent();
         }
       }
     }
   }
-
-  for (Instruction *I : InstToDelete)
-    I->eraseFromParent();
 }