[llvm] [DSE] Defer alloca store elimination for CoroSplit (PR #133918)

[Nikita Popov via llvm-commits]

================
@@ -1194,14 +1194,13 @@ struct DSEState {
 
   bool isInvisibleToCallerAfterRet(const Value *V) {
     if (isa<AllocaInst>(V))
-      return true;
+      // Defer alloca store elimination, wait for CoroSplit
+      return !F.hasFnAttribute(Attribute::PresplitCoroutine);
+
     auto I = InvisibleToCallerAfterRet.insert({V, false});
     if (I.second) {
-      if (!isInvisibleToCallerOnUnwind(V)) {
-        I.first->second = false;
-      } else if (isNoAliasCall(V)) {
+      if (isInvisibleToCallerOnUnwind(V) && isNoAliasCall(V))
----------------
nikic wrote:

Is this part of the change just an NFC refactor? If so, can you please directly land it separately? It's confusing to have it as part of this change.

https://github.com/llvm/llvm-project/pull/133918