[llvm] cde2ea3 - llvm-reduce: Defer a shouldKeep call in operand reduction (#133387)

[via llvm-commits]

Author: Matt Arsenault
Date: 2025-04-02T15:00:41+07:00
New Revision: cde2ea377d457e272ce1572d588643e5ee533c30

URL: https://github.com/llvm/llvm-project/commit/cde2ea377d457e272ce1572d588643e5ee533c30
DIFF: https://github.com/llvm/llvm-project/commit/cde2ea377d457e272ce1572d588643e5ee533c30.diff

LOG: llvm-reduce: Defer a shouldKeep call in operand reduction (#133387)

Ideally shouldKeep is only called in contexts that will successfully
do something.

Added: 
    

Modified: 
    llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp b/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
index b0bca015434fa..8b6446725b7d4 100644
--- a/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
+++ b/llvm/tools/llvm-reduce/deltas/ReduceOperands.cpp
@@ -26,8 +26,8 @@ extractOperandsFromModule(Oracle &O, ReducerWorkItem &WorkItem,
     for (auto &I : instructions(&F)) {
       if (PHINode *Phi = dyn_cast<PHINode>(&I)) {
         for (auto &Op : Phi->incoming_values()) {
-          if (!O.shouldKeep()) {
-            if (Value *Reduced = ReduceValue(Op))
+          if (Value *Reduced = ReduceValue(Op)) {
+            if (!O.shouldKeep())
               Phi->setIncomingValueForBlock(Phi->getIncomingBlock(Op), Reduced);
           }
         }