[llvm] [AMDGPU][NPM] Add isRequired to passes missing it (PR #134033)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 2 00:18:30 PDT 2025
paperchalice wrote:
> > I think we should revisit this API. Wrong by default is a bad pattern. Passes should be required by default
>
> There is in fact a lingering suggestion that we replace `PassInfoMixin` with `OptionalPassMixin` and `RequiredPassMixin` to avoid these kinds of slips and force passes to explicitly choose between the two. I remember @paperchalice working on that a while ago but I can pick that up too. @aeubanks I suppose it was your suggestion?
I want something like pass traits but seems that it conflicts with the type erasure style in current implementation...
https://github.com/llvm/llvm-project/pull/134033
More information about the llvm-commits
mailing list