[compiler-rt] [llvm] [ctxprof] root autodetection mechanism (PR #133147)

[Snehasish Kumar via llvm-commits]

================
@@ -418,12 +436,24 @@ void __llvm_ctx_profile_start_collection() {
       resetContextNode(*Root->FirstUnhandledCalleeNode);
     __sanitizer::atomic_store_relaxed(&Root->TotalEntries, 0);
   }
+  if (AutodetectDuration) {
+    auto *RD = new (__sanitizer::InternalAlloc(sizeof(RootAutoDetector)))
+        RootAutoDetector(AllFunctionsData, RootDetector, AutodetectDuration);
+    RD->start();
+  } else {
+    __sanitizer::Printf("[ctxprof] Initial NumMemUnits: %zu \n", NumMemUnits);
+  }
   __sanitizer::atomic_store_relaxed(&ProfilingStarted, true);
----------------
snehasish wrote:

Is relaxed the right choice? Is there an implication of other threads observing ProfilingStarted as true before the call to RD->start() completes?

Is this why you have the RD->join() code below?

https://github.com/llvm/llvm-project/pull/133147