[llvm] Signed integer overflow in Constraint Elimination pass LLVM issue (PR #133668)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h -- llvm/include/llvm/Support/MathExtras.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/Support/MathExtras.h b/llvm/include/llvm/Support/MathExtras.h
index 00fd097ff..789dc9e73 100644
--- a/llvm/include/llvm/Support/MathExtras.h
+++ b/llvm/include/llvm/Support/MathExtras.h
@@ -760,7 +760,7 @@ std::enable_if_t<std::is_signed_v<T>, T> SubOverflow(T X, T Y, T &Result) {
 /// Multiply two signed integers, computing the two's complement truncated
 /// result, returning true if an overflow occurred.
 template <typename T>
-std::enable_if_t<std::is_signed_v<T>, bool>MulOverflow(T X, T Y, T &Result) {
+std::enable_if_t<std::is_signed_v<T>, bool> MulOverflow(T X, T Y, T &Result) {
 #if __has_builtin(__builtin_mul_overflow)
   return __builtin_mul_overflow(X, Y, &Result);
 #else
@@ -773,7 +773,7 @@ std::enable_if_t<std::is_signed_v<T>, bool>MulOverflow(T X, T Y, T &Result) {
 
   const bool IsNegative = (X < 0) ^ (Y < 0);
 
-  // Safely compute absolute values  
+  // Safely compute absolute values
   const U AbsX = X < 0 ? (0 - static_cast<U>(X)) : static_cast<U>(X);
   const U AbsY = Y < 0 ? (0 - static_cast<U>(Y)) : static_cast<U>(Y);
 
@@ -783,12 +783,13 @@ std::enable_if_t<std::is_signed_v<T>, bool>MulOverflow(T X, T Y, T &Result) {
 
   // Safe to multiply
   U AbsResult = AbsX * AbsY;
-  Result = IsNegative ? static_cast<T>(0-AbsResult) : static_cast<T>(AbsResult);
-  
+  Result =
+      IsNegative ? static_cast<T>(0 - AbsResult) : static_cast<T>(AbsResult);
+
   // Handle INT_MIN * -1 overflow case explicitly
   if ((X == std::numeric_limits<T>::min() && Y == -1) ||
       (Y == std::numeric_limits<T>::min() && X == -1)) {
-    return true;  // overflow
+    return true; // overflow
   }
 
   U Limit = IsNegative ? MaxNegative : MaxPositive;

``````````

</details>


https://github.com/llvm/llvm-project/pull/133668