[llvm] Stop using __attribute__((retain)) in GCC builds (PR #133793)

[Matthias Braun via llvm-commits]

https://github.com/MatzeB created https://github.com/llvm/llvm-project/pull/133793

None

>From 3444de3e5287d285fa4798e4118a4f0cf254463e Mon Sep 17 00:00:00 2001
From: Matthias Braun <matze at braunis.de>
Date: Mon, 31 Mar 2025 13:36:49 -0700
Subject: [PATCH] Stop using __attribute__((retain)) in GCC builds

---
 llvm/include/llvm/Support/Compiler.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h
index ff6f5e44ae2f1..dd70362455d89 100644
--- a/llvm/include/llvm/Support/Compiler.h
+++ b/llvm/include/llvm/Support/Compiler.h
@@ -231,8 +231,15 @@
 #endif
 
 #if __has_attribute(retain)
+#if defined(__clang__) || !defined(__GNUC__)
 #define LLVM_ATTRIBUTE_RETAIN __attribute__((__retain__))
 #else
+// See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99587
+// GCC may produce "warning: ‘retain’ attribute ignored" (despite
+// __has_attribute(retain) begin 1). For now skip the attribute on GCC.
+#define LLVM_ATTRIBUTE_RETAIN
+#endif
+#else
 #define LLVM_ATTRIBUTE_RETAIN
 #endif