[llvm] c1bf5e6 - [DirectX] Fix build break caused by bitcode writer changes (#133770)

via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 31 11:39:24 PDT 2025


Author: Farzon Lotfi
Date: 2025-03-31T14:39:20-04:00
New Revision: c1bf5e62877cf3a769886505a687def47cd65e05

URL: https://github.com/llvm/llvm-project/commit/c1bf5e62877cf3a769886505a687def47cd65e05
DIFF: https://github.com/llvm/llvm-project/commit/c1bf5e62877cf3a769886505a687def47cd65e05.diff

LOG: [DirectX] Fix build break caused by bitcode writer changes (#133770)

commit:
https://github.com/llvm/llvm-project/commit/68947342b75cc71f3ac9041d11db086d8d074336
added a new `writeDIFixedPointType` function.
However, `DIFixedPointType` is not supported in DXIL so we need to add a
fail fast case for this to fix the build.

this change fixes a build break introduced by
https://github.com/llvm/llvm-project/pull/129596

Added: 
    

Modified: 
    llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
index ea33ee5759cb7..2a736c91c05c7 100644
--- a/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
+++ b/llvm/lib/Target/DirectX/DXILWriter/DXILBitcodeWriter.cpp
@@ -237,6 +237,11 @@ class DXILBitcodeWriter {
                          SmallVectorImpl<uint64_t> &Record, unsigned Abbrev);
   void writeDIBasicType(const DIBasicType *N, SmallVectorImpl<uint64_t> &Record,
                         unsigned Abbrev);
+  void writeDIFixedPointType(const DIFixedPointType *N,
+                             SmallVectorImpl<uint64_t> &Record,
+                             unsigned Abbrev) {
+    llvm_unreachable("DXIL cannot contain DIFixedPointType Nodes");
+  }
   void writeDIStringType(const DIStringType *N,
                          SmallVectorImpl<uint64_t> &Record, unsigned Abbrev) {
     llvm_unreachable("DXIL cannot contain DIStringType Nodes");


        


More information about the llvm-commits mailing list