[llvm] [IR][JumpThreading] Fix infinite recursion on compare self-reference [updated] (PR #129501)

[Matt Arsenault via llvm-commits]

================
@@ -1537,10 +1535,12 @@ Constant *JumpThreadingPass::evaluateOnPredecessorEdge(
       Constant *Op0 = nullptr;
       Constant *Op1 = nullptr;
       if (Value *V0 = CondCmp->getOperand(0); !Visited.contains(V0)) {
+        Visited.insert(V0);
         Op0 = evaluateOnPredecessorEdge(BB, PredPredBB, V0, DL, Visited);
         Visited.erase(V0);
       }
       if (Value *V1 = CondCmp->getOperand(1); !Visited.contains(V1)) {
+        Visited.insert(V1);
----------------
arsenm wrote:

can you use the iterator here to erase after 

https://github.com/llvm/llvm-project/pull/129501