[clang] [llvm] [clang][CodeGen] Generate follow-up metadata for loops in correct format (PR #131985)

[Ryotaro Kasuga via llvm-commits]

================
@@ -44,23 +44,19 @@ MDNode *LoopInfo::createPipeliningMetadata(const LoopAttributes &Attrs,
   else if (Attrs.PipelineInitiationInterval != 0)
     Enabled = true;
 
+  SmallVector<Metadata *, 4> Args;
+  Args.append(LoopProperties.begin(), LoopProperties.end());
+
   if (Enabled != true) {
-    SmallVector<Metadata *, 4> NewLoopProperties;
     if (Enabled == false) {
-      NewLoopProperties.append(LoopProperties.begin(), LoopProperties.end());
----------------
kasuga-fj wrote:

When `Enabled == std::nullopt`, `LoopProperties` was used as is, not `NewProperties`. So I think the cause is elsewhere. Anyway, it's enough to know that `llvm.mustprogress` should be appended unconditionally, thanks.

https://github.com/llvm/llvm-project/pull/131985